This is an automated email from the git hooks/post-receive script. lamby pushed a commit to branch master in repository lintian.
commit 51e416260cc4b84ce27f65e2fb8bfb132e84385d Author: Chris Lamb <[email protected]> Date: Fri Jan 5 17:43:31 2018 +0000 Emit pedantic warnings for packages that refer to a non-Git version control systems hosted in the Debian infrastructure for the upcoming salsa.debian.org migration. (Closes: #885974) --- checks/fields.desc | 15 +++++++++++++++ checks/fields.pm | 10 +++++++--- debian/changelog | 3 +++ .../debian/debian/control.in | 18 ++++++++++++++++++ .../desc | 7 +++++++ .../tags | 0 .../debian/debian/control.in | 18 ++++++++++++++++++ .../desc | 7 +++++++ .../tags | 2 ++ 9 files changed, 77 insertions(+), 3 deletions(-) diff --git a/checks/fields.desc b/checks/fields.desc index 4ca9aa4..65e5f2e 100644 --- a/checks/fields.desc +++ b/checks/fields.desc @@ -1385,3 +1385,18 @@ Info: Please move the packaging to under the *.debian.org umbrella. Alternatively, update the specified VCS field is either stale from before it was orphaned, or is otherwise wrong. + +Tag: vcs-deprecated-in-debian-infrastructure +Severity: pedantic +Certainty: certain +Info: The spcified Vcs-* header points to an area within the *.debian.org + infrastructure but refers to a version control system that has been + deprecated. + . + After 1st May 2018, Debian will not offer hosting for any version + control system other than Git. + . + Whilst maintainers are free to use other version control systems hosted + elsewhere, potential contributors are likely to be most familiar with + Git. +Ref: https://lists.debian.org/debian-devel-announce/2017/08/msg00008.html diff --git a/checks/fields.pm b/checks/fields.pm index 755612f..4e9d822 100644 --- a/checks/fields.pm +++ b/checks/fields.pm @@ -1339,10 +1339,14 @@ sub run { next; } $seen_vcs{$vcs}++; - if ( $info->field('maintainer', '') =~ /packages\@qa.debian.org/ - and $uri !~ m/\.debian\.org/) { + if ($uri =~ m/\.debian\.org/) { + tag 'vcs-deprecated-in-debian-infrastructure', "vcs-$vcs", + if $vcs ne 'git'; + } else { tag 'orphaned-package-not-maintained-in-debian-infrastructure', - "vcs-$vcs", $uri; + "vcs-$vcs", $uri + if $info->field('maintainer', '') + =~ /packages\@qa.debian.org/; } } } diff --git a/debian/changelog b/debian/changelog index 7d714bf..1812d00 100644 --- a/debian/changelog +++ b/debian/changelog @@ -12,6 +12,9 @@ lintian (2.5.68) UNRELEASED; urgency=medium * checks/fields.pm: + [CL] Warn about orphaned packages that are not maintained in the Debian infrastucture. (Closes: #886057) + + [CL] Emit pedantic warnings for packages that refer to a non-Git + version control systems hosted in the Debian infrastructure for the + upcoming salsa.debian.org migration. (Closes: #885974) * checks/huge-usr-share.pm: + [CL] Bump arch-dep-package-has-big-usr-share thresholds; they were last set in 2004. (Closes: #648755) diff --git a/t/tests/fields-vcs-deprecated-in-debian-infrastructure-unrel/debian/debian/control.in b/t/tests/fields-vcs-deprecated-in-debian-infrastructure-unrel/debian/debian/control.in new file mode 100644 index 0000000..2c6fcb3 --- /dev/null +++ b/t/tests/fields-vcs-deprecated-in-debian-infrastructure-unrel/debian/debian/control.in @@ -0,0 +1,18 @@ +Source: {$source} +Priority: optional +Section: {$section} +Maintainer: {$author} +Standards-Version: {$standards_version} +Build-Depends: {$build_depends} +Rules-Requires-Root: no +Homepage: https://lintian.debian.org/ +Vcs-Git: https://salsa.debian.org/project/user + +Package: {$source} +Architecture: {$architecture} +Depends: $\{misc:Depends\} +Description: {$description} + This is a test package designed to exercise some feature or tag of + Lintian. It is part of the Lintian test suite and may do very odd + things. It should not be installed like a regular package. It may + be an empty package. diff --git a/t/tests/fields-vcs-deprecated-in-debian-infrastructure-unrel/desc b/t/tests/fields-vcs-deprecated-in-debian-infrastructure-unrel/desc new file mode 100644 index 0000000..7e2a65a --- /dev/null +++ b/t/tests/fields-vcs-deprecated-in-debian-infrastructure-unrel/desc @@ -0,0 +1,7 @@ +Testname: fields-vcs-deprecated-in-debian-infrastructure-unrel +Version: 1.0 +Description: Check for false positives with deprecated Vcs-* fields +Options: -I -E --pedantic +Skeleton: pedantic +Test-Against: + vcs-deprecated-in-debian-infrastructure diff --git a/t/tests/fields-vcs-deprecated-in-debian-infrastructure-unrel/tags b/t/tests/fields-vcs-deprecated-in-debian-infrastructure-unrel/tags new file mode 100644 index 0000000..e69de29 diff --git a/t/tests/fields-vcs-deprecated-in-debian-infrastructure/debian/debian/control.in b/t/tests/fields-vcs-deprecated-in-debian-infrastructure/debian/debian/control.in new file mode 100644 index 0000000..380487d --- /dev/null +++ b/t/tests/fields-vcs-deprecated-in-debian-infrastructure/debian/debian/control.in @@ -0,0 +1,18 @@ +Source: {$source} +Priority: optional +Section: {$section} +Maintainer: {$author} +Standards-Version: {$standards_version} +Build-Depends: {$build_depends} +Rules-Requires-Root: no +Homepage: https://lintian.debian.org/ +Vcs-Svn: svn://anonscm.debian.org/foobar/trunk + +Package: {$source} +Architecture: {$architecture} +Depends: $\{misc:Depends\} +Description: {$description} + This is a test package designed to exercise some feature or tag of + Lintian. It is part of the Lintian test suite and may do very odd + things. It should not be installed like a regular package. It may + be an empty package. diff --git a/t/tests/fields-vcs-deprecated-in-debian-infrastructure/desc b/t/tests/fields-vcs-deprecated-in-debian-infrastructure/desc new file mode 100644 index 0000000..d33bc89 --- /dev/null +++ b/t/tests/fields-vcs-deprecated-in-debian-infrastructure/desc @@ -0,0 +1,7 @@ +Testname: fields-vcs-deprecated-in-debian-infrastructure +Version: 1.0 +Description: Check for packages with deprecated Vcs-* fields in the Debian infrastructure +Options: -I -E --pedantic +Skeleton: pedantic +Test-For: + vcs-deprecated-in-debian-infrastructure diff --git a/t/tests/fields-vcs-deprecated-in-debian-infrastructure/tags b/t/tests/fields-vcs-deprecated-in-debian-infrastructure/tags new file mode 100644 index 0000000..d985ca5 --- /dev/null +++ b/t/tests/fields-vcs-deprecated-in-debian-infrastructure/tags @@ -0,0 +1,2 @@ +I: fields-vcs-deprecated-in-debian-infrastructure source: vcs-field-uses-insecure-uri vcs-svn svn://anonscm.debian.org/foobar/trunk +P: fields-vcs-deprecated-in-debian-infrastructure source: vcs-deprecated-in-debian-infrastructure vcs-svn -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
