This is an automated email from the git hooks/post-receive script.

lamby pushed a commit to branch master
in repository lintian.

commit 293c897ef968e0f50ac4f48986034aeda57e179d
Author: Chris Lamb <la...@debian.org>
Date:   Sun Feb 4 23:04:54 2018 +0000

    Remove override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES (for now) as 
there are just too many false-positive cases to check. (Closes: #889592)
---
 checks/rules.desc                                     | 19 -------------------
 checks/rules.pm                                       |  9 ---------
 debian/changelog                                      |  4 ++++
 .../debian/debian/rules                               |  8 --------
 .../desc                                              |  5 -----
 .../tags                                              |  0
 .../debian/debian/rules                               |  9 ---------
 .../desc                                              |  5 -----
 .../tags                                              |  0
 .../debian/debian/rules                               |  7 -------
 .../desc                                              |  5 -----
 .../tags                                              |  1 -
 12 files changed, 4 insertions(+), 68 deletions(-)

diff --git a/checks/rules.desc b/checks/rules.desc
index 9d28c33..4e89148 100644
--- a/checks/rules.desc
+++ b/checks/rules.desc
@@ -337,22 +337,3 @@ Info: The <tt>debian/rules</tt> file for this package has 
a call to
  .
  Please remove the call and let dpkg-deb(1) select suitable defaults.
 Ref: #829100, dpkg-deb(1)
-
-Tag: override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
-Severity: wishlist
-Certainty: possible
-Info: The <tt>debian/rules</tt> file for this package has an
- <tt>override_dh_auto_test</tt> target that does not appear to
- check <tt>DEB_BUILD_PROFILES</tt> against <tt>nocheck</tt>.
- .
- As this check is not automatically performed by debhelper(1), the
- specified testsuite is run regardless of using the <tt>nocheck</tt>
- build profile.
- .
- Please add a check such as:
- .
-  override_dh_auto_test:
-  ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
-          ./run-upstream-testsuite
-  endif
-Ref: https://wiki.debian.org/BuildProfileSpec#Registered_profile_names
diff --git a/checks/rules.pm b/checks/rules.pm
index b31200a..8f70f7e 100644
--- a/checks/rules.pm
+++ b/checks/rules.pm
@@ -439,15 +439,6 @@ sub run {
         @{$rules_per_target{"override_$cmd"}};
     }
 
-    if (my $line = $overridden{'dh_auto_test'}) {
-        tag 'override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES',
-          "(line $line)"
-          if $rules_per_target{'override_dh_auto_test'}
-          and none { m/(DEB_BUILD_OPTIONS|nocheck)/ } @conditionals
-          and none { m/\bdh_auto_test\b/ }
-        $rules_per_target{'override_dh_auto_test'};
-    }
-
     # Make sure that all the required build dependencies are there.  Don't
     # issue missing-build-dependency errors for debhelper, since there's
     # another test that does that and it would just be a duplicate.
diff --git a/debian/changelog b/debian/changelog
index 9d67431..93686e2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -19,6 +19,10 @@ lintian (2.5.74) UNRELEASED; urgency=medium
     + [CL] Avoid emitting "Can't use an undefined value as an ARRAY
       reference" warnings when debian/patches is a file, not a directory.
       (Closes: #889535)
+  * checks/rules.{desc,pm}:
+    + [CL] Remove override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
+      (for now) as there are just too many false-positive cases to check.
+      (Closes: #889592)
   * checks/scripts.desc:
     + [CL] Improve, elaborate and tidy the long description of the
       maintainer-script-should-not-use-recursive-chown-or-chmod tag.
diff --git 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/debian/debian/rules
 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/debian/debian/rules
deleted file mode 100755
index a205d48..0000000
--- 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/debian/debian/rules
+++ /dev/null
@@ -1,8 +0,0 @@
-#!/usr/bin/make -f
-
-%:
-       dh $@
-
-# Empty target follows
-override_dh_auto_test:
-       # comment
diff --git 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/desc 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/desc
deleted file mode 100644
index 09f3706..0000000
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/desc
+++ /dev/null
@@ -1,5 +0,0 @@
-Testname: rules-dh-auto-test-does-not-check-deb-build-options-empty
-Version: 1.0
-Description: Test for missing checks for DEB_BUILD_PROFILES (empty 
false-positive)
-Test-Against:
- override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
diff --git 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/tags 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-empty/tags
deleted file mode 100644
index e69de29..0000000
diff --git 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel/debian/debian/rules
 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel/debian/debian/rules
deleted file mode 100755
index 6f702fe..0000000
--- 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel/debian/debian/rules
+++ /dev/null
@@ -1,9 +0,0 @@
-#!/usr/bin/make -f
-
-%:
-       dh $@
-
-override_dh_auto_test:
-ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
-       /bin/true
-endif
diff --git 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel/desc 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel/desc
deleted file mode 100644
index a430984..0000000
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel/desc
+++ /dev/null
@@ -1,5 +0,0 @@
-Testname: rules-dh-auto-test-does-not-check-deb-build-options-unrel
-Version: 1.0
-Description: Test for missing checks for DEB_BUILD_PROFILES (false-positive)
-Test-Against:
- override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
diff --git 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel/tags 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options-unrel/tags
deleted file mode 100644
index e69de29..0000000
diff --git 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/debian/debian/rules
 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/debian/debian/rules
deleted file mode 100755
index 07c493b..0000000
--- 
a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/debian/debian/rules
+++ /dev/null
@@ -1,7 +0,0 @@
-#!/usr/bin/make -f
-
-%:
-       dh $@
-
-override_dh_auto_test:
-       /bin/true
diff --git a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/desc 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/desc
deleted file mode 100644
index 814ee32..0000000
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/desc
+++ /dev/null
@@ -1,5 +0,0 @@
-Testname: rules-dh-auto-test-does-not-check-deb-build-options
-Version: 1.0
-Description: Test for missing checks for DEB_BUILD_PROFILES
-Test-For:
- override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES
diff --git a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags 
b/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags
deleted file mode 100644
index a94f974..0000000
--- a/t/tests/rules-dh-auto-test-does-not-check-deb-build-options/tags
+++ /dev/null
@@ -1 +0,0 @@
-I: rules-dh-auto-test-does-not-check-deb-build-options source: 
override_dh_auto_test-does-not-check-DEB_BUILD_PROFILES (line 6)

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/lintian/lintian.git

Reply via email to