Felix Lechner pushed to branch master at lintian / lintian
Commits: b61b7b2a by Felix Lechner at 2019-08-22T16:15:51Z Add missing import to checks/rules.pm. An error message appeared when each test associated with a check ran only that check. That was presumably because another check imported the module, and allowed this one to use it, but was no longer being run. Gbp-Dch: ignore - - - - - 0132b88b by Felix Lechner at 2019-08-22T16:15:51Z In Lintian, accept 'all' as a value for --check-part. This changes avoid scripting the use of the option --check-part, which is now used for almost all tests with a specific test. For a small number of tests, this option is still used, but with default value of 'all'. It made the design of the templating system much easier. This option still conflicts with other tag selection options even though the value 'all' acts as if the option had not been specified at all. It seemed more logical given the presence of the option. Gbp-Dch: ignore - - - - - 0af8a3d8 by Felix Lechner at 2019-08-22T17:00:16Z As testing default, run only declared Check; speeds up tests and makes them more specific. For tests that declare a check Lintian now runs only that check. That reduces the set of expected tags to the tags issues by that particular check. It makes the tests much more specific. The most significant effect, however, is running time. In preliminary tests, the test suite is anywhere from 20% to 33% faster than before. Adds a default '--check-part' command line option to all invocations of Lintian. Some tests that use tag selectors that conflict with that option can and do override that value. For Check:, adds a default value of 'all'. Lintian now accepts this value. It was necessary to avoid scripting the option '--check-part'. For Fill-Values-Folder:, sets default for directory that holds additional substitution variables to be added to desc. Templates can add variables that contain substitutions themselves. The files in this folder replace 'builder' and 'lintian-invocation' from before. The location of the folder can probably not be overridden because of the way the files are loaded in Test::Lintian::Prepare. The Sequence: value has not been used for some time and was already removed from all individual tests. Also removes it from here. - - - - - 1c771fc8 by Felix Lechner at 2019-08-22T17:00:32Z In Test::Lintian::Prepare, implement new templating order; also fill substitutions in substitution variables. This changes the order in which values are loaded into the test case structure. That leads to a more intuitive order in which values override one another. Now fills all values in fill-values.d and loads those values into the list of substition variables to be used in templates. This is now a powerful system that is generic enough to be used by any template that needs it. At some point, it may be desirable to switch the templating engine to Template::Toolkit. It may also be better to use their delimiter. Gbp-Dch: ignore - - - - - 9dabdb94 by Felix Lechner at 2019-08-22T17:00:32Z In Test::Lintian::Run, use new Lintian command line options and recognize Check: all. The old way of specifying Lintian's command line options lead to recursive behavior in fill-values.d. Introduces a new variable, Lintian-Command-Line, as a solution. The location of the executable was not specified as part of that command line. That way, the runner has the option to use either the unpacked or the installed version of Lintian. This feature is not currently used but could be handy if package templating and building are separated from the test suite. The runner looks up whether the Check in a test exists in Lintian. Tells it not to complain about a value of 'all'. Gbp-Dch: ignore - - - - - c424b392 by Felix Lechner at 2019-08-22T17:00:33Z In templates, move previously special files 'builder' to locations in ./fill-values.d. The templating system no longer recognizes special files like 'builder'. Instead, all files under fill-values.d are filled and loaded into the list of substitution variables. It allows templates to define their own substitution variables that contain substitutions themselves. Renames the files and moves them into their new locations. Gbp-Dch: ignore - - - - - 40594e73 by Felix Lechner at 2019-08-22T17:00:33Z In templates, move previously special file 'lintian-invocation' to locations in ./fill-values.d. The templating system no longer recognizes special files like 'lintian-invocation'. Instead, all files under fill-values.d are filled and loaded into the list of substitution variables. It allows templates to define their own substitution variables, which may contain substitutions themselves. Renames the file and moves it into the new location. Also introduces a new substition value Lintian-Command-Line to avoid circular behavior in fill-values.d. Gbp-Dch: ignore - - - - - 9f93268a by Felix Lechner at 2019-08-22T17:00:33Z Removes unecessary references to template whitelists from skeletons. The whitelist 'lintian-invocation' attempted to fill the special file 'lintian-command', but that file is no longer used. Removes that whitelist reference from all skeletons. Similarly, the whitelist 'make-builder' was used to fill the special file 'builder'. It is still needed to fill Makefile templates in all template sets except 'changes-simple-fill', whieh uses no Makefile. Removes the whitelist reference from that skeleton. Gbp-Dch: ignore - - - - - 9ce64812 by Felix Lechner at 2019-08-22T17:00:33Z Adjust template whitelist for absence of special files like 'builder' and 'lintian-command'. The template whitelist only filled the special file 'lintian-command'. The whitelist is no longer used. Deletes the whitelist. Removes the special file 'builder' from the whitelist 'make-builder'. The special file is no longer used. Gbp-Dch: ignore - - - - - e69e6852 by Felix Lechner at 2019-08-22T17:00:33Z Adjust internal harness test to automatic check selection and new default options. In t/scripts/harness/logged_prepare.t, specify a Check. Also looks for that value in the completed templating values. Gbp-Dch: ignore - - - - - ea2fac33 by Felix Lechner at 2019-08-22T17:12:47Z In tests, adjust expected tags for greater specificity; drop tags unrelated to check. For tests that declare a check Lintian now runs only that check. That reduces the set of expected tags to the tags issues by that particular check. It makes the tests much more specific. Removes all expected tags that are not related to the declared check. The impact of this step is particularly noticable for the families of tests that were duplicated as they were sorted into checks from the previous test suite. Until now, that duplication had little value; besides the ability to run only tests associated with a check, a positive, the test suite just took longer to run. With this commit, the expected tags for these families of tests began to diverge severely. In fact, they no longer share any tags at all. The most significant effect of this change, however, is running time. In preliminary tests, the test suite is anywhere from 20% to 33% faster than before. Gbp-Dch: ignore - - - - - 75ffb5f7 by Felix Lechner at 2019-08-22T17:13:34Z Adapt test control-file/source-only-upload-to-non-free-without-autobuild to new templating system Changes to the build command are no longer made through the special file 'builder'. Templating values that use substitutions themselves may now be used directly in 'desc'. Gbp-Dch: ignore - - - - - 8a2cbf28 by Felix Lechner at 2019-08-22T17:13:34Z Adapt test control-files/control-files-traversal to automatic check selection. The check is now selected automatically through the templates. The manual selection is no longer necessary, and actually conflicts. Lintian will produce an error saying that the option -C may not be specified twice. Removes the manual check selection. Gbp-Dch: ignore - - - - - 92137505 by Felix Lechner at 2019-08-22T17:13:35Z Adapt test control-files/md5sums-traversal to automatic check selection. The check is now selected automatically through the templates. The manual selection is no longer necessary, and actually conflicts. Lintian will produce an error saying that the option -C may not be specified twice. Removes the manual check selection. Gbp-Dch: ignore - - - - - a1ae0244 by Felix Lechner at 2019-08-22T17:13:35Z Adapt test runner-features/runtests-options to automatic check selection. The check is now selected automatically through the templates. The manual selection is no longer necessary, and actually conflicts. Lintian will produce an error saying that the option -C may not be specified twice. Removes the manual check selection. Gbp-Dch: ignore - - - - - 70467041 by Felix Lechner at 2019-08-22T17:13:35Z Adapt test control-file/rules-requires-root-implicitly to automatic check selection. The check is now selected automatically through the templates. The manual selection is no longer necessary, and actually conflicts. Lintian will produce an error saying that the option -C may not be specified twice. Removes the manual check selection. Gbp-Dch: ignore - - - - - 2dc3e4b8 by Felix Lechner at 2019-08-22T17:13:35Z Adapt test control-files/control-files-classifications-ctrl-script to automatic check selection. The check is now selected automatically through the templates. The manual selection is no longer necessary, and actually conflicts. Lintian will produce and error saying that -C may not be specified twice. Removes the manual check selection. Gbp-Dch: ignore - - - - - 07e4084a by Felix Lechner at 2019-08-22T17:13:35Z Adapt test control-files/control-files-classifications-no-ctrl-scripts to automatic check selection. The check is now selected automatically through the templates. The manual selection is no longer necessary, and actually conflicts. Lintian will produce an error saying that the option -C may not be specified twice. Removes the manual check selection. Gbp-Dch: ignore - - - - - edb7bb03 by Felix Lechner at 2019-08-22T17:13:35Z Adapt test debhelper/debhelper-compat-virtual-relation to automatic check selection. The check is now selected automatically through the templates. The manual selection is no longer necessary, and actually conflicts. Lintian will produce an error saying that the option -C may not be specified twice. Removes the manual check selection. Gbp-Dch: ignore - - - - - e1101595 by Felix Lechner at 2019-08-22T17:13:35Z Adapt test debian-source-dir/debian-source-dir-classifications to automatic check selection. The check is now selected automatically through the templates. The manual selection is no longer necessary, and actually conflicts. Lintian will produce an error saying that the option -C may not be specified twice. Removes the manual check selection. Gbp-Dch: ignore - - - - - 55417106 by Felix Lechner at 2019-08-22T17:13:35Z Adapt test files/contains-build-path to new templating system. Changes to the build command are no longer made through the special file 'builder'. Templating values that use substitutions themselves may now be used directly in 'desc'. Gbp-Dch: ignore - - - - - 983be9dd by Felix Lechner at 2019-08-22T17:13:35Z Adapt test files/files-package-contains-usr-unmerged-pathnames to automatic check selection. The check is now selected automatically through the templates. The manual selection is no longer necessary, and actually conflicts. Lintian will produce an error saying that the option -C may not be specified twice. Removes the manual check selection. Gbp-Dch: ignore - - - - - 7bd6a74a by Felix Lechner at 2019-08-22T17:13:35Z Adapt test lintian-features/lintian-check-tags-file to automatic check selection. The Lintian option '--tags-from-file' used by this test conflicts with the automatic test selection. Overrides the default Lintian command line options. Turns off the automatic selection of Check: all. Gbp-Dch: ignore - - - - - 623e3f68 by Felix Lechner at 2019-08-22T17:13:36Z Adapt test lintian-features/lintian-display-level to new templating system. Changes to the Lintian invocation are no longer made through the special file 'lintian-command'. Templating values that use substitutions themselves may now be used directly in 'desc'. Gbp-Dch: ignore - - - - - 220cc642 by Felix Lechner at 2019-08-22T17:13:36Z Adapt test md5sums/md5sums-traversal to new templating system This test used to specify which checks to run, but that is now incompatible unless the default Lintian command line options are overridden. Turns off the manual selection. The selection of three checks before was unusual. From now on, the test suite will run only the declared check md5sums. One tag disappeared as a result. Gbp-Dch: ignore - - - - - d57798b8 by Felix Lechner at 2019-08-22T17:13:36Z Adapt test python/python-script-uses-unversioned-python-in-shebang to automatic check selection. The check is now selected automatically through the templates. The manual selection is no longer necessary, and actually conflicts. Lintian will produce an error saying that the option -C may not be specified twice. Removes the manual check selection. Gbp-Dch: ignore - - - - - ef5cc454 by Felix Lechner at 2019-08-22T17:13:36Z Adapt test scripts/scripts-does-not-start-with-shebang to automatic check selection. The check is now selected automatically through the templates. The manual selection is no longer necessary, and actually conflicts. Lintian will produce an error saying that the option -C may not be specified twice. Removes the manual check selection. Gbp-Dch: ignore - - - - - 7800c10d by Felix Lechner at 2019-08-22T17:13:36Z Adapt test scripts/scripts-maintainer-script-classification to automatic check selection. The check is now selected automatically through the templates. The manual selection is no longer necessary, and actually conflicts. Lintian will produce an error saying that the option -C may not be specified twice. Removes the manual check selection. Gbp-Dch: ignore - - - - - 30 changed files: - checks/rules.pm - commands/lintian.pm - lib/Test/Lintian/Prepare.pm - lib/Test/Lintian/Run.pm - t/defaults/desc - t/scripts/harness/logged-prepare.t - t/skeletons/changes - t/skeletons/deb - t/skeletons/source-native - t/skeletons/source-non-native - t/skeletons/upload-builder-only - t/skeletons/upload-native - t/skeletons/upload-non-native - t/tags/checks/application-not-library/application-not-library/tags - t/tags/checks/appstream-metadata/appstream-metadata/tags - t/tags/checks/binaries/binaries-development-package-ships-elf-binary-in-path/tags - t/tags/checks/binaries/binaries-doesnt-match-sonames/tags - t/tags/checks/binaries/binaries-from-other-arch/tags - t/tags/checks/binaries/binaries-general/tags - t/tags/checks/binaries/binaries-golang/tags - t/tags/checks/binaries/binaries-missing-depends-on-libc/tags - t/tags/checks/binaries/binaries-missing-depends-on-numpy-abi/tags - t/tags/checks/binaries/binaries-missing-depends/tags - t/tags/checks/binaries/binaries-multiarch-same/tags - t/tags/checks/binaries/binaries-spelling/tags - t/tags/checks/binaries/binaries-unsafe-open/tags - t/tags/checks/binaries/legacy-binary/tags - t/tags/checks/binaries/legacy-debug/tags - t/tags/checks/binaries/legacy-libbaz/tags - t/tags/checks/changelog-file/changelog-distribution-does-not-match-changes-file/tags The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/lintian/lintian/compare/71d551c1cb2bb59b4f3de06a0fa8aa7be5ffadd2...7800c10dd68b839a9c264804a473b10f2bb14e3c -- View it on GitLab: https://salsa.debian.org/lintian/lintian/compare/71d551c1cb2bb59b4f3de06a0fa8aa7be5ffadd2...7800c10dd68b839a9c264804a473b10f2bb14e3c You're receiving this email because of your account on salsa.debian.org.
