Chris Lamb pushed to branch buster-backports at lintian / lintian
Commits: dc6e5987 by Chris Lamb at 2019-10-20T10:29:40Z Open new changelog entry. Gbp-Dch: ignore - - - - - c4e15aa4 by Felix Lechner at 2019-10-21T04:57:10Z In check cruft, use new internal tagging mechanism ->tag instead of the global Lintian::Tag::tag. Switches this check to a new tagging facility that will make it possible to sort tags before they are issued. It will also eliminate some error prone global variables surrounding profiles. Please do not use the old global 'tag' facility from Lintian::Tag in this check anymore. - - - - - 1a9b8458 by Felix Lechner at 2019-10-21T04:57:10Z In checks split off from 'files', do not use ->source to get name of source package. The name of this new facility conflicts with the basic facet 'source' used to check source packages. The facility will be removed in the near future. Access the name of the source package via the processable instead. Gbp-Dch: ignore - - - - - b1fbfeca by Felix Lechner at 2019-10-21T04:57:10Z Remove facility to access name of source package from role 'Lintian::Check'. The name of this facility conflicted with the basic facet 'source' that is invoked when checking source packages. No check is using this facility presently. Removes it. Gbp-Dch: ignore - - - - - 023487b7 by Felix Lechner at 2019-10-22T14:41:56Z In test scripts, allow 'files' as the sole entry point for checks. This harness test ensures checks are viable. With changing facilities for checks, it needs frequent adjustment. Some checks only iterate over files and have no other entry points. Gbp-Dch: ignore - - - - - 918e1127 by Felix Lechner at 2019-10-22T14:43:22Z In role Lintian::Check, run entry point 'files' only for binary and udeb processables. The entry point 'files' iterates over files to be installed and therefore only makes sense for installation packages (formerly called binary packages), including udeb. This entry point was previously also called for all other Lintian inputs, such as source files, but none of the checks aimed at them used it. Gbp-Dch: ignore - - - - - 28ab6787 by Felix Lechner at 2019-10-22T14:46:29Z In Lintian::Collect::Binary, provide separate function to get list of conffiles. Both Lintian::Binary::Collect the check 'conffiles' produces this list in slightly different ways. This consolidates the scanning in Lintian::Binary::Collect. Eliminates duplication of code and simplifies the check. Gbp-Dch: ignore - - - - - bf6afd6c by Felix Lechner at 2019-10-22T14:48:57Z In check apache2, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - 0cae0ef7 by Felix Lechner at 2019-10-22T14:48:57Z In check conffiles, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - 5d081390 by Felix Lechner at 2019-10-22T14:48:57Z In check duplicate-files, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - 34447112 by Felix Lechner at 2019-10-22T14:48:57Z In check fields/architecture, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - cec911bf by Felix Lechner at 2019-10-22T14:48:57Z In check files/empty-package, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - 599585ae by Felix Lechner at 2019-10-22T14:48:57Z In check files/maintainer-scripts, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - bd88e04a by Felix Lechner at 2019-10-22T14:52:27Z In check huge-usr-share, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Improves the accuracy of the space calculations by using unrounded values as inputs, and by rounding the output with sprintf over int. Gbp-Dch: ignore - - - - - dda7c171 by Felix Lechner at 2019-10-22T14:52:27Z In check init.d, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - 067ec6cb by Felix Lechner at 2019-10-22T14:52:27Z In check manpages, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - a23578e0 by Felix Lechner at 2019-10-22T14:52:27Z In check md5sums, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - a6e08881 by Felix Lechner at 2019-10-22T14:52:27Z In check menus, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - deb7f172 by Felix Lechner at 2019-10-22T14:52:28Z In check nodejs, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - 9de45f40 by Felix Lechner at 2019-10-22T14:52:28Z In check ocaml, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - 9f110693 by Felix Lechner at 2019-10-22T14:52:28Z In check pe, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - 3123f50d by Felix Lechner at 2019-10-22T14:52:28Z In check python, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Uses standard facilities from Lintian::Binary::Collect to determine the interpreter used in scripts. Gbp-Dch: ignore - - - - - 17ed82f6 by Felix Lechner at 2019-10-22T14:52:28Z In check symlinks, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - 83023688 by Felix Lechner at 2019-10-22T14:52:28Z In check systemd, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - f49ba827 by Felix Lechner at 2019-10-22T14:52:28Z In check usrmerge, use new facility to loop over installed 'files'. These are additional attempts to break existing code into manageable pieces by using standardized components. The 'files' facility was inspired by the check 'files'. It loops over the shipped files for installation packages. May include some additional refactoring. Gbp-Dch: ignore - - - - - dab49016 by Sylvestre Ledru at 2019-10-22T20:13:46Z Emit a warning for overly-long binary package fields. (Closes: #942493) Signed-off-by: Chris Lamb <[email protected]> - - - - - 6ebc3c3b by Chris Lamb at 2019-10-22T20:50:42Z Warn about packages that use the deprecated ADTTMP autopkgtest variable. - - - - - 713e9ac5 by Felix Lechner at 2019-10-23T20:38:35Z Rename Lintian::Processable::Group, use Moo; add many clean ups and refactorings. Much of the functionality regarding groups was consolidated in this class. A major source was commands/lintian.pm, which is now much shorter. Rationalizes the addition of new "processables" to groups, for which there were previously three different algorithms in various parts of the code base. The best way to add a file to the pool is to add it to a newly created group, and add that to the pool. An important realization was that the group, by virtue of its ability to draw connections between source and installation packages, is the primary unit being checked by Lintian. Renames the class to Lintian::Processable::Group from the previous Lintian::ProcessableGroup (without colons). Converts the Group class to use the Moo object system. The changes are incomplete and will continue as global variables are being factored out. Gbp-Dch: ignore - - - - - fb7c6165 by Felix Lechner at 2019-10-23T20:40:27Z Rename Lintian::Processable::Pool, use Moo; add many clean ups and refactorings. Much of the functionality regarding pools was consolidated in this class. A major source was commands/lintian.pm. The goal is hide most processing from higher code layers, which will make it less error prone and more readable. The Lintian::Processable::Group elements contained in this pool are the primary unit Lintian runs on. The best way to add a file to the pool is to add it to a newly created group, and then add it to the pool. Renames the class to Lintian::Processable::Pool from the previous Lintian::ProcessablePool (without colons). Converts the Pool class to use the Moo object system. The changes are incomplete and will continue as global variables are being factored out. Gbp-Dch: ignore - - - - - 53002feb by Felix Lechner at 2019-10-23T20:40:51Z In Processable, add a function to calculate a proper group identifier. The identifier was previously calculated externally by users of this class. It appeared useful to provide a uniform and unambiguous implementation for an identifier. Gbp-Dch: ignore - - - - - ba56dcca by Felix Lechner at 2019-10-23T20:42:46Z Convert Lintian::Lab to Moo; refactor destruction to ensure reliable clean ups. Simplifies the many ways in which Lab cleanups were handled. With some luck, this will continue to help fight space problems on lindsay.d.o. Gbp-Dch: ignore - - - - - 5b3f9904 by Felix Lechner at 2019-10-23T20:43:18Z In commands/lintian, use new class Lintian::Processable::Pool. Much of the execution moved to library modules. The result is a more readable file in Lintian's master script. Procedural details are now hidden in appropriate layers. The objective is to make the Lintian code base easier to read for new contributors. The changes are incomplete and will continue as global variables are being factored out. Gbp-Dch: ignore - - - - - 8e4e87e9 by Felix Lechner at 2019-10-23T20:43:59Z In checks, adjust method calls for new names in Lintian::Processable::Group. The new names referenced here are a little bit shorter than before. The new naming also refects an emphasis on the group as the central processing element by virtue of its ability to draw connections between source and installation packages. Gbp-Dch: ignore - - - - - a6d28ec1 by Felix Lechner at 2019-10-23T20:44:40Z In Lab::Entry, add missing import. A similar import was removed from Lintian::Lab, which had been included here and avoided the error that appeared then. Gbp-Dch: ignore - - - - - 4533ee0b by Felix Lechner at 2019-10-23T20:45:09Z Adjust POD texts for Processable name changes. Updated the links in the documentation. This commit contains no code changes. Gbp-Dch: ignore - - - - - 5e568a6c by Felix Lechner at 2019-10-23T20:45:36Z Adjust internal harness test for new Processable module names. The two modules referenced here were renamed. Uses the new names. Gbp-Dch: ignore - - - - - ed55c4ec by Felix Lechner at 2019-10-23T20:45:58Z In Lintian::FrontendUtils, remove a subroutine that is no longer used. The functionality of the routine, which was only called from one place, was transferred inline into its sole consumer. Removes it from here. Gbp-Dch: ignore - - - - - 95373000 by Felix Lechner at 2019-10-25T00:34:18Z Update profiles; different order but no changes. Gbp-Dch: ignore - - - - - b8d02ca8 by Felix Lechner at 2019-10-25T20:21:10Z Add script 'generate-qa-list-from-udd.pl' to generate 'qa-list.txt' from UDD database. The script sends all package information to stdout. Debugging information, if enabled with '-d', will go to stderr. An automated invocation (in bash) would probably look similar to: TEMPFILE="$(mktemp)" "$LINTIAN_ROOT/reporting/generate-qa-list.pl" > "$TEMPFILE" mv "$TEMPFILE" "$HTML_DIR/qa-list.txt" This script includes tags for all of 'unstable' and 'experimental', but debug packages are not included. (I am trying to find them in UDD.) That is why the counts produced by this script differ from the original qa-list.txt. This script aggregates the tags from all architectures and the two releases through an ingenious row numbering and a DISTINCT query (thanks to #postgresql). Like the original qa-list.txt, the resulting counts do not necessarily correspond to any particular architecture or release, but the results are probably the most useful for package maintainers. Gbp-Dch: ignore - - - - - 171e4e9b by Felix Lechner at 2019-10-25T22:28:06Z In private/generate-profiles.pl, extract auto-reject tags from data posted by FTP Master. The script downloads the most recent data for FTP Master auto rejects from their URL at: https://ftp-master.debian.org/static/lintian.tags The resulting profile is not used by the FTP Master team, but is made available to users via the command line option -F. For details, please see Bug#943536. The script previously used local copies of similar data but it was outdated and was in an unfamiliar format. The old, static copies of that data will be removed from the Git repo in the near future. The module LWP::Simple, which is used to download, was not added as a prerequisite to d/control. The script is intended to be run manually by the development team, and is not shipped to users. The data file from FTP Master is in YAML format, and should be parsed as such. The current approach via regular expressions is not ideal. - - - - - 170d64fa by Felix Lechner at 2019-10-25T22:28:06Z Remove old copies of FTP Master auto-reject specification. The data files are outdated and require manual reformatting. The script that generate the profiles no longer uses them. It instead downloads the source data from the official URL at: https://ftp-master.debian.org/static/lintian.tags The static data files are no longer needed. They are removed. Gbp-Dch: ignore - - - - - b674161f by Felix Lechner at 2019-10-25T22:28:06Z Update Master FTP auto-reject profile with latest data. This incorporates the most recent information from the offical repository for the data at: https://ftp-master.debian.org/static/lintian.tags This profile is not used by the FTP Master team, but is made available to users via the command line option -F, presumably to check planned uploads for potential rejection. For details, please see Bug#943536. The profile was outdated and has been updated. Gbp-Dch: ignore - - - - - ecd99c2d by Felix Lechner at 2019-10-26T14:18:39Z In tests, rename pre_build to pre-build. For historical reasons, some of the test helper scripts such as pre_build had underscores in their names while others had hyphens. This commit is part of a series to standardize the names using hyphens. Hyphens can be easier to read but also have drawbacks. Significant in this context is that Makefile variables may not contain hyphens. Gbp-Dch: ignore - - - - - 193af22a by Felix Lechner at 2019-10-26T14:18:55Z In tests, rename pre_build.in to pre-build.in. For historical reasons, some of the test helper scripts such as pre_build had underscores in their names while others had hyphens. This commit is part of a series to standardize the names using hyphens. Hyphens can be easier to read but also have drawbacks. Significant in this context is that Makefile variables may not contain hyphens. Gbp-Dch: ignore - - - - - f84ed202 by Felix Lechner at 2019-10-26T14:19:01Z In tests, rename pre_upstream to pre-upstream. For historical reasons, some of the test helper scripts such as pre_upstream had underscores in their names while others had hyphens. This commit is part of a series to standardize the names using hyphens. Hyphens can be easier to read but also have drawbacks. Significant in this context is that Makefile variables may not contain hyphens. Gbp-Dch: ignore - - - - - f808d880 by Felix Lechner at 2019-10-26T14:19:06Z In tests, rename post_build.in to post-build.in. For historical reasons, some of the test helper scripts such as post_build had underscores in their names while others had hyphens. This commit is part of a series to standardize the names using hyphens. Hyphens can be easier to read but also have drawbacks. Significant in this context is that Makefile variables may not contain hyphens. Gbp-Dch: ignore - - - - - e468eb00 by Felix Lechner at 2019-10-26T14:19:13Z In tests, rename post_test to post-test. For historical reasons, some of the test helper scripts such as post_test had underscores in their names while others had hyphens. This commit is part of a series to standardize the names using hyphens. Hyphens can be easier to read but also have drawbacks. Significant in this context is that Makefile variables may not contain hyphens. Gbp-Dch: ignore - - - - - 042e4d1d by Felix Lechner at 2019-10-26T14:19:19Z In tests, rename test_calibration to test-calibration. For historical reasons, some of the test helper scripts such as test_calibration had underscores in their names while others had hyphens. This commit is part of a series to standardize the names using hyphens. Hyphens can be easier to read but also have drawbacks. Significant in this context is that Makefile variables may not contain hyphens. Gbp-Dch: ignore - - - - - b7c845a9 by Felix Lechner at 2019-10-26T14:19:24Z Fix template whitelists for the migration from underscores to hyphens in test helper scripts. For historical reasons, some of the test helper scripts such as pre_build had underscores in their names while others had hyphens. This commit is part of a series to standardize the names using hyphens. This adjusts the template whitelists to allow filling of the renamed files. Hyphens can be easier to read but also have drawbacks. Significant in this context is that Makefile variables may not contain hyphens. Gbp-Dch: ignore - - - - - 3e1f2a39 by Felix Lechner at 2019-10-26T14:19:34Z Fix templates for the migration from underscores to hyphens in test helper scripts. For historical reasons, some of the test helper scripts such as pre_build had underscores in their names while others had hyphens. This commit is part of a series to standardize the names using hyphens. This adjusts the templates, which provide default versions for some of the renamed files. Hyphens can be easier to read but also have drawbacks. Significant in this context is that Makefile variables may not contain hyphens. Gbp-Dch: ignore - - - - - 8b206550 by Felix Lechner at 2019-10-26T14:19:38Z Fix Test::Lintian::Run for the migration from underscores to hyphens in test helper scripts. For historical reasons, some of the test helper scripts such as pre_build had underscores in their names while others had hyphens. This commit is part of a series to standardize the names using hyphens. This adjusts the test runner to use the renamed files. Hyphens can be easier to read but also have drawbacks. Significant in this context is that Makefile variables may not contain hyphens. Gbp-Dch: ignore - - - - - 268741f8 by Chris Lamb at 2019-10-26T18:03:17Z Release lintian/2.30.0 into unstable. - - - - - 912eee2e by Chris Lamb at 2019-10-29T12:34:26Z Merge tag '2.30.0' into buster-backports Release lintian/2.30.0 into unstable. Format: 1.8 Date: Sat, 26 Oct 2019 18:03:17 +0000 Source: lintian Architecture: source Version: 2.30.0 Distribution: unstable Urgency: medium Maintainer: Debian Lintian Maintainers <[email protected]> Changed-By: Chris Lamb <[email protected]> Closes: 942493 Changes: lintian (2.30.0) unstable; urgency=medium . [ Chris Lamb ] * Warn about packages that use the deprecated $ADTTMP autopkgtest variable. . [ Sylvestre Ledru ] * Emit a warning for overly-long binary package fields. (Closes: #942493) . [ Felix Lechner ] * Generate the qa-list.txt data file from the Ultimate Debian Database and update this file in the package. * Extract the auto-reject tags from the data published by the FTP Master team and update locally. * In the cruft check, use the new ->tag subroutine instead of the Lintian::Tag::tag global. Checksums-Sha1: 4b880b408de78f79837f96b195423eee0b9e2df1 3037 lintian_2.30.0.dsc 2cb643d03e4bc390c2eff1a49d009a270df7f20a 1797308 lintian_2.30.0.tar.xz 76b4c990b244e19bb6bcbc8819c1d010e165950a 15638 lintian_2.30.0_amd64.buildinfo Checksums-Sha256: 06156d23e45c9c831edb15c97ad980da265da9471a9f5bbfff4d6ffb710d706d 3037 lintian_2.30.0.dsc 386c3dda9f9d259129326c995497f0bfe0892f9b4a526986991285ae3f417bf0 1797308 lintian_2.30.0.tar.xz ad26b4cccbb2756bf2e78a1b1045fba2f17c23ffdd984d0aaff9054f9e6728bf 15638 lintian_2.30.0_amd64.buildinfo Files: 9ff38d0ae92b222e5ffa55381d064413 3037 devel optional lintian_2.30.0.dsc 815bec1554c33051eeeaea6f6b1da040 1797308 devel optional lintian_2.30.0.tar.xz 41306b8794ce9e3e82b104c272e0bc41 15638 devel optional lintian_2.30.0_amd64.buildinfo * tag '2.30.0': (52 commits) Release lintian/2.30.0 into unstable. Fix Test::Lintian::Run for the migration from underscores to hyphens in test helper scripts. Fix templates for the migration from underscores to hyphens in test helper scripts. Fix template whitelists for the migration from underscores to hyphens in test helper scripts. In tests, rename test_calibration to test-calibration. In tests, rename post_test to post-test. In tests, rename post_build.in to post-build.in. In tests, rename pre_upstream to pre-upstream. In tests, rename pre_build.in to pre-build.in. In tests, rename pre_build to pre-build. Update Master FTP auto-reject profile with latest data. Remove old copies of FTP Master auto-reject specification. In private/generate-profiles.pl, extract auto-reject tags from data posted by FTP Master. Add script 'generate-qa-list-from-udd.pl' to generate 'qa-list.txt' from UDD database. Update profiles; different order but no changes. In Lintian::FrontendUtils, remove a subroutine that is no longer used. Adjust internal harness test for new Processable module names. Adjust POD texts for Processable name changes. In Lab::Entry, add missing import. In checks, adjust method calls for new names in Lintian::Processable::Group. ... - - - - - 1d580092 by Chris Lamb at 2019-10-29T12:34:47Z Rebuild for buster-backports. - - - - - 30 changed files: - checks/apache2.pm - checks/binaries.pm - checks/conffiles.pm - checks/cruft.pm - checks/debian/changelog.pm - checks/debian/control.pm - checks/debian/copyright.pm - checks/duplicate-files.pm - checks/fields/architecture.pm - checks/files/apt.pm - checks/files/build-path.pm - checks/files/cmake.pm - checks/files/contents.pm - checks/files/documentation.pm - checks/files/embedded-libraries.pm - checks/files/empty-package.pm - checks/files/hierarchy-standard.pm - checks/files/ieee-data.pm - checks/files/maintainer-scripts.pm - checks/files/perl.pm - checks/files/privacy-breach.pm - checks/files/python.pm - checks/files/vim.pm - checks/huge-usr-share.pm - checks/init.d.pm - checks/manpages.pm - checks/md5sums.pm - checks/menus.pm - checks/nodejs.pm - checks/ocaml.pm The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/lintian/lintian/compare/d8c548fe330f2b51d1f5ab88644cd727f2ce79bb...1d5800926327e98bd6de02ea79b4c867c2129201 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/compare/d8c548fe330f2b51d1f5ab88644cd727f2ce79bb...1d5800926327e98bd6de02ea79b4c867c2129201 You're receiving this email because of your account on salsa.debian.org.
