Chris Lamb pushed to branch buster-backports at lintian / lintian
Commits: 54db49cb by Chris Lamb at 2020-09-11T09:32:51+01:00 Open new changelog entry. Gbp-Dch: ignore - - - - - 0cb21700 by Felix Lechner at 2020-09-11T06:29:13-07:00 Fix a broken link in the manual pages. The link was not properly changed in recent commits when lintian-info was split into two program. In our updated Lintian terminology, 'tags' describe conditions that should be fixed in general terms. Lintian then adds a situation-specific context for the maintainer's benefit. The combined message, which is specific to a package, is called a hint. The manual page confused the two terms. Gbp-Dch: ignore - - - - - 60d0b26d by Felix Lechner at 2020-09-11T14:34:52-07:00 Replace documentation references to lintian-info(1) with lintian-explain-tags(1), as appropriate. Gbp-Dch: ignore - - - - - d634a0d5 by Chris Lamb at 2020-09-12T22:48:16+01:00 Clarify which Vcs-* the vcs-field-not-canonical tag is being emitted for, and update its long description to remove misleading messages. (Closes: #970201) - - - - - 7ea4febd by Pino Toscano at 2020-09-13T11:51:36+01:00 Also detect duplicate Debian menu files for games. When checking whether a Debian menu file duplicates a desktop file, also normalize the /usr/games/ paths; this will catch also all the Debian menu files with command="/usr/games/foo". Signed-off-by: Chris Lamb <[email protected]> - - - - - 36f68419 by Sebastian Ramacher at 2020-09-13T11:53:18+01:00 Mark libavresample-dev from ffmpeg as being obsolete in favour of libswresample-dev. Signed-off-by: Chris Lamb <[email protected]> - - - - - 66c1ffbb by Felix Lechner at 2020-09-13T07:39:45-07:00 Make diffstat an attribute in Processable; parse it there. Further reduces the reliance on brittle paths in the temporary directory. Also fixes a bug with incorrect nativeness, which can be seen in the tag changes for following test. It is now detected as native: % more t/recipes/checks/debian/source-dir/source-format-1.0/build-spec/fill-values Skeleton: upload-native Testname: source-format-1.0 Source-Format: 1.0 Description: General tests for debian/source/* checks Gbp-Dch: ignore - - - - - e2bdd77d by Felix Lechner at 2020-09-13T14:22:30-07:00 Integrate the last remaining helper,objdump-info-helper, into Processable.. Obviates the need for any helper directories in Lintian and saves spinning up a Perl interpreter. Other improvements for simpler data structures and faster execution are scheduled for the near future. Gbp-Dch: ignore - - - - - 5b64a168 by Felix Lechner at 2020-09-14T00:06:46-07:00 Prepare parsing of readelf output for xargs-style processing. This pre-parser should allow the use of xargs-like strategies for the calls to readelf, either directly via xargs or by using a similar command grouping strategy implemented Perl. The code explains it thus: Special case - readelf will not prefix the output with "File: $name" if it only gets one ELF file argument, so act as if it did... (but it does "the right thing" if passed a static lib >.>) In fact, if readelf always emitted that File: header, we could simply use xargs directly on readelf and just parse its output in the loop below. A Perl implementation of xargs would know when readelf receives only one argument, and could compensate for the missing line with a File indicator, but such acrobatics are probably not necessary with the change here. Gbp-Dch: ignore - - - - - d1d902ad by Felix Lechner at 2020-09-14T09:05:27-07:00 Remove obsolete scripts-missing-versioned-depends-on-init-system-helpers-without. (Closes: #932378) Based on the version of init-system-helpers that is now available in stable, I saw no way to remedy or otherwise repurpose the tag. It is obsolete. This commit drops the tag from Lintian. >From the original bug report: > init-system-helpers version in stable are 1.56+nmu1. > This makes the required versioning superfluous. Thanks to Jörg Frings-Fürst <[email protected]> for the original report (made over a year ago), for his patience, and also for the ping earlier today. - - - - - b53a2fe8 by Felix Lechner at 2020-09-16T12:54:29-07:00 Make orig index fully functional; subject to some path name limitations. The index was previously only working with respect to the list of names, but not for access to the unpacked files. The code currently merges indices for multiple tarballs. Right now that only works with some restrictions on path names. Error messages are issued accordingly. Gbp-Dch: ignore - - - - - 66d167ff by Felix Lechner at 2020-09-16T12:54:41-07:00 Provide uniform file-based information facilities for all indices. Simplifies setup of the indices, and will ulimately allow the use of the general Index class without subclassing. Gbp-Dch: ignore - - - - - d90f04a1 by Felix Lechner at 2020-09-16T21:11:46-07:00 Fold Index subclasses into their Processable attributes and use the Index base class instead. Simplifies greatly the logic behind the initialization of file indices. It also finally unmantles, with small vestiges in Processable::Installable, the logic of the old Unpacker. File indices are now unpacked an initialized when they are used for the first time. The relevant code can be located easily in the Processable attribute that provides the respective index. A basic example can be found in Processable::Installed, while the version in Processable::Patched is more advanced. A key element of the new data flow is that tags can be issued anywhere that a Processable is available. In the present case, tags are issued when there are errors during unpacking. In the old Unpacker, the tags were issued at later point in checks based on temporary files. That separation was both brittle and confusing, which is why the new data flow is superior. Gbp-Dch: ignore - - - - - b2bb5268 by Xavier Guimard at 2020-09-17T15:12:09+02:00 Fix pkg-js-tools test search Recent pkg-js-tools allows DD to have a different test between build and autopkgtest. This patch search test file in the same order than pkg-js-tools, so next test (non empty test) is done with the good file. - - - - - ee125788 by Felix Lechner at 2020-09-17T16:01:18-07:00 Repurpose diff-contains tags to work on all Debian changes in other formats. Reduces the number of tags issued for nuisance files in upstream sources, but sharply increases the issuance for such files when a maintainer has control over them. Until now, most checks for nuisance files were turned off for formats other than 1.0. According to trends.d.n, however, over ninety percent of packages in unstable use format 3.0 (quilt). As a result of a change made recently, the orig index is now also unpacked. It is thus possible to compare those files with the corresponding sources in the 'patched' index, which are used to build packages. By virtue of that comparion a very detailed and accurate picture emerges as to the maintainer's impact on the source tree. Substantial benefits are expected, especially for non-native packages, which are extremely common in the archive. Renames some tags named for the 1.0 source format from 'diff-contains-*' to a format-neutral 'debian-adds-*'. The cruft check will be split into smaller pieces in the near future. - - - - - 30a3c191 by Felix Lechner at 2020-09-17T20:32:14-07:00 Eliminate the NULL and an accidental return for diffstat; improve parsing.. The return statement was probably left over from a conversion. In this case, the next statement is more appropriate. In an archive-wide run, it gets rid of warnings such as these: % bin/lintian /mirror/debian/pool/main/e/ez-ipupdate/ez-ipupdate_3.0.11b8-13.4.1.dsc Warning in group ez-ipupdate/3.0.11b8-13.4.1: Can't use an undefined value as a HASH reference at /lcl/lechner/lintian/git/checks/debian/patches.pm line 82. warning: cannot run debian/patches check on package source:ez-ipupdate/3.0.11b8-13.4.1 skipping check of source:ez-ipupdate/3.0.11b8-13.4.1 Warning in group ez-ipupdate/3.0.11b8-13.4.1: Can't use an undefined value as a HASH reference at /lcl/lechner/lintian/git/checks/debian/source-dir.pm line 68. warning: cannot run debian/source-dir check on package source:ez-ipupdate/3.0.11b8-13.4.1 skipping check of source:ez-ipupdate/3.0.11b8-13.4.1 Also modifies the regular expression to allow zero spaces between the pipe symbols and the number. The offending line looked like this: debian/patches/010_rebootstrap.diff |15191 +++++++++++++++++++++++++++++ Either one would have solved the warnings. This one does both. Gbp-Dch: ignore - - - - - 29e8eccc by Felix Lechner at 2020-09-17T21:50:44-07:00 When unpacking orig tarballs only drop common path segments when they are directories. The sources for emacs-session are special in that they contain a single file, called session.el, and no directories. The common path segment was the name of the single file. Removal of that name failed because it was not a directory (warning below). The bug was that unwanted path segmenta must be directories. It should now be ensured by the addition of slashes in two regular expressions: The first expression requires a slash in paths used to determine the common prefix. It discards regular files in the root directory. The second expression extracts the prefix and, due to the added slash, can no longer match regular files. The second edit may not be required to fix the bug. In an archive-wide run, avoids many warnings like these: % bin/lintian /mirror/debian/pool/main/e/emacs-session/emacs-session_2.4b-2.dsc Warning in group emacs-session/2.4b-2: Can't call method "is_dir" on an undefined value at /lcl/lechner/lintian/git/bin/../lib/Lintian/Index.pm line 500. warning: cannot run cruft check on package source:emacs-session/2.4b-2 skipping check of source:emacs-session/2.4b-2 Warning in group emacs-session/2.4b-2: Can't call method "is_dir" on an undefined value at /lcl/lechner/lintian/git/bin/../lib/Lintian/Index.pm line 500. warning: cannot run debian/copyright/dep5 check on package source:emacs-session/2.4b-2 skipping check of source:emacs-session/2.4b-2 Warning in group emacs-session/2.4b-2: Can't call method "is_dir" on an undefined value at /lcl/lechner/lintian/git/bin/../lib/Lintian/Index.pm line 500. warning: cannot run files/names check on package source:emacs-session/2.4b-2 skipping check of source:emacs-session/2.4b-2 Warning in group emacs-session/2.4b-2: Can't call method "is_dir" on an undefined value at /lcl/lechner/lintian/git/bin/../lib/Lintian/Index.pm line 500. warning: cannot run origtar check on package source:emacs-session/2.4b-2 skipping check of source:emacs-session/2.4b-2 Gbp-Dch: ignore - - - - - d92a3885 by Chris Lamb at 2020-09-18T09:46:19+00:00 Release lintian/2.95.0 into unstable. - - - - - 35d9b65c by Chris Lamb at 2020-09-20T13:24:19+01:00 Merge tag '2.95.0' into buster-backports Release lintian/2.95.0 into unstable. Format: 1.8 Date: Fri, 18 Sep 2020 09:46:19 +0000 Source: lintian Architecture: source Version: 2.95.0 Distribution: unstable Urgency: medium Maintainer: Debian Lintian Maintainers <[email protected]> Changed-By: Chris Lamb <[email protected]> Closes: 932378 970201 Changes: lintian (2.95.0) unstable; urgency=medium . * Summary of tag changes: + Added: - no-debian-changes - source-contains-cmake-cache-file - source-contains-debian-substvars + Removed: - empty-debian-diff - missing-versioned-depends-on-init-system-helpers + Renamed: - diff-contains-arch-control-dir -> debian-adds-arch-control-dir (etc.) . [ Chris Lamb ] * Clarify which Vcs-* the vcs-field-not-canonical tag is being emitted for, and update its long description to remove misleading messages. (Closes: #970201) . [ Felix Lechner ] * Remove the obsolete scripts-missing-versioned-depends-on-init-system-helpers-without tag.. (Closes: #932378) * Repurpose diff-contains-* tags to work on all Debian changes in other formats. . [ Pino Toscano ] * Also detect duplicate Debian menu files for games. . [ Sebastian Ramacher ] * Mark libavresample-dev from ffmpeg as being obsolete in favour of libswresample-dev. . [ Xavier Guimard ] * Fix the search for pkg-js-tools tests. Checksums-Sha1: 00d66dfa8f12c472a67d51fde2d88a3a58047698 1556 lintian_2.95.0.dsc d35e55d5bc72b1a2305ee05c3276de09cd77ee44 1979076 lintian_2.95.0.tar.xz b902eb4f4fb7affe46330bac8e0fc97a0f4ee2d6 4956 lintian_2.95.0_amd64.buildinfo Checksums-Sha256: afdbb487e64e4b1145afa400e5b91225ceb00a6abfe5b5171aef930b3a3bd104 1556 lintian_2.95.0.dsc 8c7b85e260b4f6fbc9919a346ce116fc29ca5beddf62349836152cc1abf75460 1979076 lintian_2.95.0.tar.xz 3e4ce9806fafa38738fecd8e711e4ea41b6875861e76a54e9e69d9a0643c3957 4956 lintian_2.95.0_amd64.buildinfo Files: 606d682b91e18e72f76fc4981336a811 1556 devel optional lintian_2.95.0.dsc 988c96bf2be714754c985bbe5a54458b 1979076 devel optional lintian_2.95.0.tar.xz 49a76ff76130b46cac0a3eb5ee66cde4 4956 devel optional lintian_2.95.0_amd64.buildinfo * tag '2.95.0': Release lintian/2.95.0 into unstable. When unpacking orig tarballs only drop common path segments when they are directories. Eliminate the NULL and an accidental return for diffstat; improve parsing. Repurpose diff-contains tags to work on all Debian changes in other formats. Fix pkg-js-tools test search Fold Index subclasses into their Processable attributes and use the Index base class instead. Provide uniform file-based information facilities for all indices. Make orig index fully functional; subject to some path name limitations.. Remove obsolete scripts-missing-versioned-depends-on-init-system-helpers-without. (Closes: #932378) Prepare parsing of readelf output for xargs-style processing. Integrate the last remaining helper,objdump-info-helper, into Processable. Make diffstat an attribute in Processable; parse it there. Mark libavresample-dev from ffmpeg as being obsolete in favour of libswresample-dev. Also detect duplicate Debian menu files for games. Clarify which Vcs-* the vcs-field-not-canonical tag is being emitted for, and update its long description to remove misleading messages. (Closes: #970201) Replace documentation references to lintian-info(1) with lintian-explain-tags(1), as appropriate. Fix a broken link in the manual pages. Open new changelog entry. - - - - - 2d9cf33f by Chris Lamb at 2020-09-20T13:24:24+01:00 Rebuild for buster-backports. - - - - - 30 changed files: - bin/lintian - checks/cruft.pm - checks/debian/patches.pm - checks/debian/source-dir.pm - checks/fields/vcs.pm - checks/languages/javascript/nodejs.pm - checks/menu-format.pm - checks/scripts.pm - data/fields/obsolete-packages - debian/changelog - debian/lintian.install - debian/lintian.links - doc/README.developers - doc/lintian.rst - − helpers/coll/objdump-info-helper - lib/Lintian/IO/Select.pm - lib/Lintian/Index.pm - − lib/Lintian/Index/Control.pm - − lib/Lintian/Index/Installed.pm - lib/Lintian/Index/Objdump.pm - − lib/Lintian/Index/Orig.pm - − lib/Lintian/Index/Patched.pm - lib/Lintian/Processable/Control.pm - lib/Lintian/Processable/Diffstat.pm - lib/Lintian/Processable/Installable.pm - lib/Lintian/Processable/Installed.pm - lib/Lintian/Processable/Orig.pm - lib/Lintian/Processable/Patched.pm - lib/Lintian/Processable/Source.pm - lib/Lintian/Util.pm The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/5a16bd5cbd4a3e615cb62d0afdbb00f6d4a899bd...2d9cf33f055d8712266d72e940efa788e0576536 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/5a16bd5cbd4a3e615cb62d0afdbb00f6d4a899bd...2d9cf33f055d8712266d72e940efa788e0576536 You're receiving this email because of your account on salsa.debian.org.
