Felix Lechner pushed to branch master at lintian / lintian
Commits: cfc5355d by Felix Lechner at 2021-09-05T17:42:41-07:00 Add back a final newline mistakenly removed when cleaning non-UTF-8 bytes from build logs. Makes it easier to tell apart failing build tasks for test packages, especially on Salsa. Gbp-Dch: ignore - - - - - 503fe6d1 by Felix Lechner at 2021-09-05T17:43:55-07:00 Fix two failing test cases for autoconf 2.71 on Salsa CI in unstable. For build-systems/automake/automake-general, the error message was: autoreconf: error: configure.in: AC_INIT not found; not an autoconf script? dh_autoreconf: error: autoreconf -f -i returned exit code 1 By the way, it is not clear that this test and the corresponding check belong into a separate category for 'automake'. The naming of the configure file seems to be a matter of autotools proper. For build-systems/autotools/cruft-autotools-pkg-config-macro-not-cross-compilation-safe, the error message was autoreconf: warning: 'configure.ac' and 'configure.in' both present. autoreconf: proceeding with 'configure.ac' autoreconf: error: configure.ac: AC_INIT not found; not an autoconf script? dh_autoreconf: error: autoreconf -f -i returned exit code 1 That test was split into two: one for the common configure.ac filename and another for the older configure.in name. The missing AC_INIT declarations were added to all three tests. Also, all three tests were marked to build only sources (the installables are not needed).. Gbp-Dch: ignore - - - - - b8c88b5a by Felix Lechner at 2021-09-05T18:51:57-07:00 Ignore special attributes like 'remove-on-upgrade' in DEBIAN/conffiles. (Closes: #993531, #993711) For the package in the first bug report, Lintian now produces the following hints: $ bin/lintian --no-tag-display-limit /mirror/debian/pool/main/c/chkboot/chkboot_1.3-8_all.deb E: chkboot: conffile-is-not-in-package etc/kernel/postinst.d/zzz-chkboot E: chkboot: conffile-is-not-in-package etc/kernel/postrm.d/zzz-chkboot The two remaining hints appear to be legitimate: $ more DEBIAN/conffiles remove-on-upgrade /etc/kernel/postinst.d/zzz-chkboot remove-on-upgrade /etc/kernel/postrm.d/zzz-chkboot /etc/apt/apt.conf.d/05chkboot /etc/default/chkboot /etc/init.d/chkboot /etc/profile.d/chkboot-profilealert.sh $ dpkg-deb -c /mirror/debian/pool/main/c/chkboot/chkboot_1.3-8_all.deb drwxr-xr-x root/root 0 2021-09-02 10:37 ./ drwxr-xr-x root/root 0 2021-09-02 10:37 ./etc/ drwxr-xr-x root/root 0 2021-09-02 10:37 ./etc/apt/ drwxr-xr-x root/root 0 2021-09-02 10:37 ./etc/apt/apt.conf.d/ -rw-r--r-- root/root 118 2020-10-25 06:36 ./etc/apt/apt.conf.d/05chkboot drwxr-xr-x root/root 0 2021-09-02 10:37 ./etc/default/ -rw-r--r-- root/root 593 2021-09-02 10:37 ./etc/default/chkboot drwxr-xr-x root/root 0 2021-09-02 10:37 ./etc/init.d/ -rwxr-xr-x root/root 718 2020-10-25 06:36 ./etc/init.d/chkboot drwxr-xr-x root/root 0 2021-09-02 10:37 ./etc/profile.d/ -rw-r--r-- root/root 347 2021-09-02 10:37 ./etc/profile.d/chkboot-profilealert.sh drwxr-xr-x root/root 0 2021-09-02 10:37 ./usr/ drwxr-xr-x root/root 0 2021-09-02 10:37 ./usr/bin/ -rwxr-xr-x root/root 3614 2021-09-02 10:37 ./usr/bin/chkboot -rwxr-xr-x root/root 782 2021-09-02 10:37 ./usr/bin/chkboot-check -rwxr-xr-x root/root 763 2021-09-02 10:37 ./usr/bin/chkboot-desktopalert drwxr-xr-x root/root 0 2021-09-02 10:37 ./usr/lib/ drwxr-xr-x root/root 0 2021-09-02 10:37 ./usr/lib/systemd/ drwxr-xr-x root/root 0 2021-09-02 10:37 ./usr/lib/systemd/system/ -rw-r--r-- root/root 265 2020-10-25 06:36 ./usr/lib/systemd/system/chkboot.service drwxr-xr-x root/root 0 2021-09-02 10:37 ./usr/libexec/ drwxr-xr-x root/root 0 2021-09-02 10:37 ./usr/libexec/chkboot/ -rwxr-xr-x root/root 700 2021-09-02 10:37 ./usr/libexec/chkboot/chkboot-bootcheck -rwxr-xr-x root/root 723 2020-05-14 00:57 ./usr/libexec/chkboot/chkboot-update drwxr-xr-x root/root 0 2021-09-02 10:37 ./usr/share/ drwxr-xr-x root/root 0 2021-09-02 10:37 ./usr/share/doc/ drwxr-xr-x root/root 0 2021-09-02 10:37 ./usr/share/doc/chkboot/ -rw-r--r-- root/root 284 2020-05-14 00:57 ./usr/share/doc/chkboot/NEWS.Debian.gz -rw-r--r-- root/root 1204 2021-09-02 10:37 ./usr/share/doc/chkboot/changelog.Debian.gz -rw-r--r-- root/root 1322 2021-09-02 10:36 ./usr/share/doc/chkboot/copyright drwxr-xr-x root/root 0 2021-09-02 10:37 ./usr/share/man/ drwxr-xr-x root/root 0 2021-09-02 10:37 ./usr/share/man/man8/ -rw-r--r-- root/root 644 2021-09-02 10:37 ./usr/share/man/man8/chkboot-check.8.gz -rw-r--r-- root/root 706 2021-09-02 10:37 ./usr/share/man/man8/chkboot-desktopalert.8.gz -rw-r--r-- root/root 994 2021-09-02 10:37 ./usr/share/man/man8/chkboot.8.gz The attributes for conffiles were added in recent versions of Debhelper, Dpkg, or both. For Lintian itself, which is the subject of the second bug, the action here was only partially successful. The hints mentined there are gone, but a new one appeared: E: lintian: conffile-is-not-in-package etc/lintianrc Upon inspection, the latest version of Debhelper seems to have replaced the instruction in d/lintian.maintscript rm_conffile /etc/lintianrc 2.90.0~ lintian with this line in DEBIAN/conffiles remove-on-upgrade /etc/lintianrc but Lintian stopped shipping /etc/lintianrc some time ago. [1] For this comparison, we compared the build artifacts available on Salsa with the version 2.104.0 of Lintian currently in unstable. A bug report for Debhelper is forthcoming. The Lintian maintainers will be copied. [1] https://salsa.debian.org/lintian/lintian/-/commit/4b878e14d9758f7b44210ae65fc26acd30c67dc6 - - - - - c7a1c7f8 by Felix Lechner at 2021-09-05T18:53:53-07:00 In the test suite, rename expected 'tags' to the more accurately titled 'hints'; utilities too. Renames all manner of things from tags* to hints* throughout the test suite. They were left behind in the first big rename. Follows the proposed convention that the hints intended for maintainers are composed of tags that are augmented by a helpful context. The word 'tag' now refers to the condition that gave rise to a hint's issuance. Gbp-Dch: ignore - - - - - 30 changed files: - lib/Lintian/Processable/Control/Conffiles.pm - lib/Lintian/Util.pm - lib/Test/Lintian/Filter.pm - lib/Test/Lintian/Hooks.pm - lib/Test/Lintian/Output/EWI.pm - lib/Test/Lintian/Output/Universal.pm - lib/Test/Lintian/Run.pm - private/tagadjust → private/hintadjust - private/tagdiff → private/hintdiff - private/tagextract → private/hintextract - private/tagsort → private/hintsort - private/runtests - private/split-desc - t/defaults/desc - t/recipes/checks/apache2/apache2-modules-general/eval/tags → t/recipes/checks/apache2/apache2-modules-general/eval/hints - t/recipes/checks/apache2/apache2-webapplications-general/eval/tags → t/recipes/checks/apache2/apache2-webapplications-general/eval/hints - t/recipes/checks/application-not-library/application-not-library/eval/tags → t/recipes/checks/application-not-library/application-not-library/eval/hints - t/recipes/checks/appstream-metadata/appstream-metadata/eval/tags → t/recipes/checks/appstream-metadata/appstream-metadata/eval/hints - t/recipes/checks/apt/files-foo-in-bar/eval/tags → t/recipes/checks/apt/files-foo-in-bar/eval/hints - t/recipes/checks/binaries/binaries-development-package-ships-elf-binary-in-path/eval/tags → t/recipes/checks/binaries/binaries-development-package-ships-elf-binary-in-path/eval/hints - t/recipes/checks/binaries/binaries-doesnt-match-sonames/eval/tags → t/recipes/checks/binaries/binaries-doesnt-match-sonames/eval/hints - t/recipes/checks/binaries/binaries-embedded-libs/eval/tags → t/recipes/checks/binaries/binaries-embedded-libs/eval/hints - t/recipes/checks/binaries/binaries-from-other-arch/eval/tags → t/recipes/checks/binaries/binaries-from-other-arch/eval/hints - t/recipes/checks/binaries/binaries-general/eval/tags → t/recipes/checks/binaries/binaries-general/eval/hints - t/recipes/checks/binaries/binaries-golang/eval/tags → t/recipes/checks/binaries/binaries-golang/eval/hints - t/recipes/checks/binaries/binaries-hardening/eval/tags → t/recipes/checks/binaries/binaries-hardening/eval/hints - t/recipes/checks/binaries/binaries-libc-link/eval/tags → t/recipes/checks/binaries/binaries-libc-link/eval/hints - t/recipes/checks/binaries/binaries-misplaced/eval/tags → t/recipes/checks/binaries/binaries-misplaced/eval/hints - t/recipes/checks/binaries/binaries-missing-depends-on-libc/eval/tags → t/recipes/checks/binaries/binaries-missing-depends-on-libc/eval/hints - t/recipes/checks/binaries/binaries-missing-depends-on-numpy-abi/eval/tags → t/recipes/checks/binaries/binaries-missing-depends-on-numpy-abi/eval/hints The diff was not included because it is too large. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/6497a5f9540651973d7132b2d2d5fb22737583f2...c7a1c7f8f37db845667e5c82a714b29010e68d59 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/compare/6497a5f9540651973d7132b2d2d5fb22737583f2...c7a1c7f8f37db845667e5c82a714b29010e68d59 You're receiving this email because of your account on salsa.debian.org.
