Felix Lechner pushed to branch master at lintian / lintian
Commits:
fa4f9645 by Felix Lechner at 2022-01-19T03:49:15-08:00
Fix formatting in a tag description.
The content itself seemed a bit dated, too, but was not improved.
Gbp-Dch: ignore
- - - - -
0b08b61a by Felix Lechner at 2022-01-19T04:00:46-08:00
Add missing argument with profile data to fix test of generated HTML via tidy.
Gbp-Dch: ignore
- - - - -
829deb4c by Felix Lechner at 2022-01-19T04:02:13-08:00
Balance HTML tags in the granting reason for a screen.
Led to poor output on the website.
Found after the test with 'tidy' was fixed in the preceeding commit.
Gbp-Dch: ignore
- - - - -
3 changed files:
- t/scripts/tags/fields.t
- tags/a/ambiguous-paragraph-in-dep5-copyright.tag
- tags/v/very-long-line-length-in-source-file.tag
Changes:
=====================================
t/scripts/tags/fields.t
=====================================
@@ -156,14 +156,12 @@ for my $tag_path (@tag_paths) {
select $fh;
print "<!DOCTYPE html><head><title>$tag_name</title></head><body>";
- $html_output->describe_tags([$tag]);
+ $html_output->describe_tags($profile->data, [$tag]);
say '</body>';
select *STDOUT;
close $fh;
- print $html_description;
-
my $tidy_out;
my $tidy_err;
=====================================
tags/a/ambiguous-paragraph-in-dep5-copyright.tag
=====================================
@@ -1,19 +1,17 @@
Tag: ambiguous-paragraph-in-dep5-copyright
Severity: warning
Check: debian/copyright/dep5
-See-Also: Bug#652380,
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
-Explanation: The paragraph has a "License" and a "Copyright" field, but no
- "Files" field. Technically, this is a valid paragraph per the DEP 5
- specification. However, it is mostly likely a mistake.
+Explanation: The paragraph has both <code>License</code> and
+ <code>Copyright</code> fields, but no <code>Files</code> field. The paragraph
+ is technically valid according to the DEP 5 specification, but it is probably
+ a mistake.
.
- If it is a <code>stand-alone license paragraph</code>, the "Copyright"
- field is not needed and should be removed. On the other hand, if it
- is a <code>files paragraph</code>, it is missing the "Files" field.
+ If the paragraph is a "stand-alone" license paragraph, the
<code>Copyright</code>
+ field is not needed. If it is, on the other hand, "files" paragraph, the
+ <code>Files</code> field is missing.
.
- Please note that while the "Files" field was optional in some cases
- in some of the earlier draft versions, it is mandatory in *all*
- <code>files paragraphs</code> in the current specification.
- .
- Lintian will attempt to guess what you intended and continue based on
- its guess. If the guess is wrong, you may see spurious tags related
- to this paragraph.
+ The <code>Files</code> field was at some point optional in some circumstances
+ but is now mandatory in all "files" paragraphs.
+See-Also:
+ Bug#652380,
+ https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
=====================================
tags/v/very-long-line-length-in-source-file.tag
=====================================
@@ -25,7 +25,7 @@ Screen: autotools/long-lines
Advocates: Russ Allbery <[email protected]>
Reason:
Upstream sources using <code>autoconf</code> have traditionally been
- distributed with generated <code>./configure<code> scripts as well as
+ distributed with generated <code>./configure</code> scripts as well as
other third-party <code>m4</code> macro files such as <code>libtool</code>.
.
When paired with <code>automake</code>, there may also be some intermediate
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/d0e94e79b177f265d7bd5e5cb9028fcea66dd71f...829deb4c45e950b741221728ab0e6115740a92c3
--
View it on GitLab:
https://salsa.debian.org/lintian/lintian/-/compare/d0e94e79b177f265d7bd5e5cb9028fcea66dd71f...829deb4c45e950b741221728ab0e6115740a92c3
You're receiving this email because of your account on salsa.debian.org.
