Nilesh Patra pushed to branch master at lintian / lintian
Commits: 579d080b by Gioele Barabucci at 2023-09-29T21:36:27+00:00 Remove obsolete tag "package-supports-alternative-init-but-no-init.d-script" Debian policy Section 9.11 "Alternate init systems", the section responsible for `package-supports-alternative-init-but-no-init.d-script` has been deleted [1,2] and the check is thus no longer needed. Rewrite the test to focus only on `directory-in-etc-sv-directory-without-executable-run-script`. [1] https://www.debian.org/doc/debian-policy/ch-opersys.html#alternate-init-systems [2] https://salsa.debian.org/dbnpolicy/policy/-/commit/d9cfe27611e86cc5e1496d1db73d1ad2761a259c - - - - - 13 changed files: - lib/Lintian/Check/InitD.pm - t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/bar.service → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/bar.service - t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/control.in → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/control.in - t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/install → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/install - t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/rules → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/rules - t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/run → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/run - + t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/fill-values - + t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/eval/desc - + t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/eval/hints - − t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/fill-values - − t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/eval/desc - − t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/eval/hints - − tags/p/package-supports-alternative-init-but-no-init.d-script.tag Changes: ===================================== lib/Lintian/Check/InitD.pm ===================================== @@ -708,25 +708,6 @@ sub check_defaults { sub visit_installed_files { my ($self, $item) = @_; - # check for missing init.d script when alternative init system is present - - if ( $item =~ m{etc/sv/(?<svc>[^/]+)/run$} - || $item =~ m{(?<usr>usr/)?lib/systemd/system/(?<svc>[^/@]+)\.service}) - { - - my ($usr, $service) = ($+{usr} // $EMPTY, $+{svc}); - - $self->pointed_hint( - 'package-supports-alternative-init-but-no-init.d-script', - $item->pointer) - unless $self->processable->installed->resolve_path( - "etc/init.d/${service}") - || $self->processable->installed->resolve_path( - "${usr}lib/systemd/system/${service}.path") - || $self->processable->installed->resolve_path( - "${usr}lib/systemd/system/${service}.timer"); - } - if ($item =~ m{etc/sv/([^/]+)/$}) { my $service = $1; ===================================== t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/bar.service → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/bar.service ===================================== ===================================== t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/control.in → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/control.in ===================================== ===================================== t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/install → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/install ===================================== ===================================== t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/rules → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/rules ===================================== ===================================== t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/debian/run → t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/debian/run ===================================== ===================================== t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/build-spec/fill-values ===================================== @@ -0,0 +1,3 @@ +Skeleton: upload-native +Testname: directory-in-etc-sv-directory-without-executable-run-script +Description: Check for directories in /etc/sv missing run script ===================================== t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/eval/desc ===================================== @@ -0,0 +1,2 @@ +Testname: directory-in-etc-sv-directory-without-executable-run-script +Check: init-d ===================================== t/recipes/checks/init-d/directory-in-etc-sv-directory-without-executable-run-script/eval/hints ===================================== @@ -0,0 +1 @@ +directory-in-etc-sv-directory-without-executable-run-script (binary): directory-in-etc-sv-directory-without-executable-run-script etc/sv/foo/run [etc/sv/foo/] ===================================== t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/build-spec/fill-values deleted ===================================== @@ -1,3 +0,0 @@ -Skeleton: upload-native -Testname: package-supports-alternative-init-but-no-init.d-script -Description: Check for daemon with missing init.d script ===================================== t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/eval/desc deleted ===================================== @@ -1,2 +0,0 @@ -Testname: package-supports-alternative-init-but-no-init.d-script -Check: init-d ===================================== t/recipes/checks/init-d/package-supports-alternative-init-but-no-init.d-script/eval/hints deleted ===================================== @@ -1,3 +0,0 @@ -package-supports-alternative-init-but-no-init.d-script (binary): package-supports-alternative-init-but-no-init.d-script [lib/systemd/system/bar.service] -package-supports-alternative-init-but-no-init.d-script (binary): package-supports-alternative-init-but-no-init.d-script [etc/sv/foo/run] -package-supports-alternative-init-but-no-init.d-script (binary): directory-in-etc-sv-directory-without-executable-run-script etc/sv/foo/run [etc/sv/foo/] ===================================== tags/p/package-supports-alternative-init-but-no-init.d-script.tag deleted ===================================== @@ -1,14 +0,0 @@ -Tag: package-supports-alternative-init-but-no-init.d-script -Severity: info -Check: init-d -See-Also: debian-policy 9.11 -Explanation: The package provides daemon, but contains no init.d script - Packages that provide services (daemons), like cron daemon or web servers, - may provide init.d script for starting that services with sysvinit. - Optionally, packages can also provide integration with alternative init - systems. - . - Package in question provides integration with some alternative init system, - but corresponding init.d script is absent. - . - See <code>init-d-script</code>(5) for one of possible ways writing init.d scripts. View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/579d080bff96a068abdd7eed566aca15d39fe6b9 -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/579d080bff96a068abdd7eed566aca15d39fe6b9 You're receiving this email because of your account on salsa.debian.org.
