[Git][lintian/lintian][master] Check for "Priority: optional" field in binary packages only if the source...

[@pollo]

Louis-Philippe Véronneau pushed to branch master at lintian / lintian


Commits:
7c1f9291 by Nilesh Patra at 2026-01-02T05:23:43+05:30
Check for "Priority: optional" field in binary packages only if the source 
package specifies it as optional/omits it (Closes: #1124442)

- - - - -


1 changed file:

- lib/Lintian/Check/Debian/Control/Field/Priority.pm


Changes:

=====================================
lib/Lintian/Check/Debian/Control/Field/Priority.pm
=====================================
@@ -32,23 +32,29 @@ with 'Lintian::Check';
 sub source {
     my ($self) = @_;
 
+    my $field = 'Priority';
     my $control = $self->processable->debian_control;
     my $source_fields = $control->source_fields;
     my $control_item = $self->processable->debian_control->item;
-    my $position = $source_fields->position('Priority');
+    my $position = $source_fields->position($field);
     my $pointer = $control_item->pointer($position);
 
     $self->pointed_hint('redundant-priority-optional-field', $pointer)
-      if $source_fields->value('Priority') eq 'optional';
+      if $source_fields->value($field) eq 'optional';
 
     # Priority may also be present in the binary stanza
-    for my $installable ($control->installables) {
-        my $installable_fields = $control->installable_fields($installable);
-        my $installable_position = $installable_fields->position('Priority');
-        my $installable_pointer= $control_item->pointer($installable_position);
-        $self->pointed_hint('redundant-priority-optional-field',
-            $installable_pointer)
-          if $installable_fields->value('Priority') eq 'optional';
+    # check for the same only if it is optional in the source stanza
+    if (!$source_fields->declares($field)
+        || $source_fields->value($field) eq 'optional') {
+        for my $installable ($control->installables) {
+            my $installable_fields= $control->installable_fields($installable);
+            my $installable_position= $installable_fields->position($field);
+            my $installable_pointer
+              = $control_item->pointer($installable_position);
+            $self->pointed_hint('redundant-priority-optional-field',
+                $installable_pointer)
+              if $installable_fields->value($field) eq 'optional';
+        }
     }
 
     return;



View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/7c1f929196368ee598fcbd840d10a54565d70593

-- 
View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/7c1f929196368ee598fcbd840d10a54565d70593
You're receiving this email because of your account on salsa.debian.org.