Louis-Philippe Véronneau pushed to branch master at lintian / lintian


Commits:
e76f391c by Nilesh Patra at 2026-06-21T01:20:11+00:00
Do not flag autopkgtests which have d/t/control along with `Testsuite` in 
d/control as superficial (Closes: #1033103)

- - - - -


8 changed files:

- lib/Lintian/Check/Testsuite.pm
- + 
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/build-spec/debian/control.in
- + 
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/build-spec/debian/tests/control
- + 
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/build-spec/debian/tests/test-1
- + 
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/build-spec/debian/tests/test-2
- + 
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/build-spec/fill-values
- + 
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/eval/desc
- + 
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/eval/hints


Changes:

=====================================
lib/Lintian/Check/Testsuite.pm
=====================================
@@ -119,7 +119,9 @@ sub source {
         my @thorough
           = grep { $_->value('Restrictions') !~ m{\bsuperficial\b} } @sections;
         $self->pointed_hint('superficial-tests', $tests_control->pointer)
-          if @sections && !@thorough;
+          if @sections
+          && !@thorough
+          && (@testsuites == 0 || @testsuites == @unknown);
 
         my @skip_not_inst
           = grep { $_->value('Restrictions') =~ m{\bskip-not-installable\b} }


=====================================
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/build-spec/debian/control.in
=====================================
@@ -0,0 +1,18 @@
+Source: [% $source %]
+Priority: optional
+Section: libs
+Maintainer: [% $author %]
+Standards-Version: [% $standards_version %]
+Testsuite: autopkgtest-pkg-nodejs
+Build-Depends: [% $build_depends %]
+Rules-Requires-Root: no
+
+Package: [% $source %]
+Architecture: [% $package_architecture %]
+Pre-Depends: ${misc:Pre-Depends}
+Depends: ${misc:Depends}, ${shlibs:Depends}
+Description: [% $description %]
+ This is a test package designed to exercise some feature or tag of
+ Lintian.  It is part of the Lintian test suite and may do very odd
+ things.  It should not be installed like a regular package.  It may
+ be an empty package.


=====================================
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/build-spec/debian/tests/control
=====================================
@@ -0,0 +1,7 @@
+Tests: test-1
+Restrictions:
+ superficial
+
+Tests: test-2
+Restrictions:
+ superficial


=====================================
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/build-spec/debian/tests/test-1
=====================================
@@ -0,0 +1,2 @@
+#!/bin/sh
+exit 0


=====================================
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/build-spec/debian/tests/test-2
=====================================
@@ -0,0 +1,2 @@
+#!/bin/sh
+exit 0


=====================================
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/build-spec/fill-values
=====================================
@@ -0,0 +1,3 @@
+Skeleton: source-non-native
+Testname: superficial-with-testsuite-autopkg-pkg-test
+Description: All declared tests carry Restrictions: superficial along with a 
Testsuite: autopkgtest-pkg-go in d/control


=====================================
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/eval/desc
=====================================
@@ -0,0 +1,3 @@
+Testname: superficial-with-testsuite-autopkg-pkg-test
+Check: testsuite
+Test-Against: superficial-tests


=====================================
t/recipes/checks/testsuite/superficial-with-testsuite-autopkg-pkg-test/eval/hints
=====================================
@@ -0,0 +1 @@
+



View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/e76f391ce46bb97521b01d47e20891d98c978290

-- 
View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/e76f391ce46bb97521b01d47e20891d98c978290
You're receiving this email because of your account on salsa.debian.org. Manage 
all notifications: https://salsa.debian.org/-/profile/notifications | Help: 
https://salsa.debian.org/help


Reply via email to