Hi Otavio, On Thu, Apr 24, 2008 at 04:20:13PM -0300, Otavio Salvador wrote: > Tiago Bortoletto Vaz <[EMAIL PROTECTED]> writes: > > > Hey Daniel, > > > > Please consider my last two patches which improves a little the rescue > > flavor for live-helper. > > Both patches looks good however a minor issue is the comment. Please > try to keep it on the bellow format: > > <short description> > <empty line> > <detailed description> > > Example: > > -- > add missing tools to rescue flavor > > Adds few missing tools, mainly to filesystem recovery. The list is > mostly based on System Rescue CD project. > -- > > Another tip is to use a commit for a single thing. You shouldn't add > new things to rescue and sort it in same commit. > > Obviously this is minor and probably Daniel won't deny the merging > due that but it's good to use this concepts for next patches.
Thanks for the tips, I'll be more careful with my comments and commits. Regards, -- Tiago Bortoletto Vaz http://tiagovaz.org 0xA504FECA - http://pgp.mit.edu GNU/Linux user #188687
signature.asc
Description: Digital signature
_______________________________________________ debian-live-devel mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/debian-live-devel
