El 06/04/12 20:21, intrigeri escribió:
Hi,
adrian15 wrote (06 Apr 2012 17:23:45 GMT) :
I think I've finally managed to make the patch.
Thank you.
I've even improved the part about checking that the iso was mounted
that intrigeri pointed out at:
http://lists.debian.org/debian-live/2011/09/msg00067.html
So you have replaced
grep -q /live/findiso /proc/mounts&& umount /root/live/findiso
with
[ ! -z ${mountpoint} ]&& umount /root/live/findiso
It seems more fragile to me than what the original patch did (although
it did in a way I did not like); but maybe you can explain us why this
new check is sufficient and/or better suited than the old one?
Well, actually, I wanted to ask you what did you mean when you said that
exactly but I didn't think of sending you an email.
This is my own interpretation of what you wrote and I can't explain if
it's sufficient or better suited than the old one.
I can re-submit the patch without this change or try to implement
whatever you meant if you explain it.
Other than that, this patch is fine with me.
Regards,
That's good.
adrian15
--
Support free software. Donate to Super Grub Disk. Apoya el software
libre. Dona a Super Grub Disk. http://www.supergrubdisk.org/donate/
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
Archive: http://lists.debian.org/[email protected]