Gaudenz Steinlin <[email protected]> wrote: > - In some parts it looks like it should be a general wlan driver > selection mechanism. Which would be great, but then overrides are > stored in /usr/share/live/config/broadcom-sta/ and the script is > called 1190-broadcom-sta.
the variable is generic, the driver handling is not, that's how it should be. otherwise you would no single wlan-driver= bootparameter but one for each driver. > - It uses 14e44 as a first filter in the script. While it's true that > the ID of all currently supported devices starts with this string, the > broadcom vendor ID is only 14e4. The last 4 is part of the device ID. i don't think so. http://www.pcidatabase.com/vendor_details.php?id=767 > - The blacklisting logic is the wrong way around. If broadcom-sta is > selected as a driver, all entries in > /etc/modprobe.d/broadcom-sta-dkms.conf should be blacklisted. If it's > not selected, they should NOT be blacklisted. Additionally the wl > kernel module should be blacklisted in this case. it was indeed inverted, thanks. > - checking for a state file makes this script basically useless with > persistency on removable media. When moving to live media (ie USB > stick) from one system to another you want to rerun this script each > time. State files are nice for user preferences, but I don't see a use > case for them for hardware configuration. this is #701824 which needs a generic solution in all live-config components, not just this single one. as keeping the behaviour consistent is important, this has to wait until #701824 gets worked on by someone. -- Address: Daniel Baumann, Donnerbuehlweg 3, CH-3012 Bern Email: [email protected] Internet: http://people.progress-technologies.net/~daniel.baumann/ -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: https://lists.debian.org/[email protected]
