Your message dated Thu, 07 Dec 2017 19:58:44 +0000 with message-id <[email protected]> and subject line Bug#881941: fixed in live-build 1:20171207 has caused the Debian Bug report #881941, regarding live-build: Creation of .disk/mkisofs is broken to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 881941: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881941 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: live-build Version: 1:20170920 Severity: normal Tags: patch Hi, currently .disk/mkisofs gets created by appending an echo statement to the temporary script binary.sh whicht gets executed to actually run xorriso. However this creates the following error in build.log: ---------------8<------------------- [...] [2017-11-16 20:52:38] lb binary_checksums P: Begin creating binary md5sum.txt... [2017-11-16 20:52:38] lb binary_iso P: Begin building binary iso image... The following NEW packages will be installed: isolinux libburn4{a} libisoburn1{a} libisofs6{a} libjte1{a} xorriso The following packages are RECOMMENDED but will NOT be installed: syslinux-common 0 packages upgraded, 6 newly installed, 0 to remove and 0 not upgraded. Need to get 1154 kB of archives. After unpacking 2367 kB will be used. Get: 1 http://ftp.debian.org/debian stretch/main amd64 isolinux all 3:6.03+dfsg-14.1 [94.0 kB] Get: 2 http://ftp.debian.org/debian stretch/main amd64 libburn4 amd64 1.4.6-1 [156 kB] Get: 3 http://ftp.debian.org/debian stretch/main amd64 libjte1 amd64 1.20-2+b1 [28.4 kB] Get: 4 http://ftp.debian.org/debian stretch/main amd64 libisofs6 amd64 1.4.6-1 [198 kB] Get: 5 http://ftp.debian.org/debian stretch/main amd64 libisoburn1 amd64 1.4.6-1+b1 [379 kB] Get: 6 http://ftp.debian.org/debian stretch/main amd64 xorriso amd64 1.4.6-1+b1 [299 kB] Fetched 1154 kB in 0s (2760 kB/s) [...] Setting up libisofs6:amd64 (1.4.6-1) ... Setting up libisoburn1:amd64 (1.4.6-1+b1) ... Setting up xorriso (1.4.6-1+b1) ... Processing triggers for libc-bin (2.24-11+deb9u1) ... xorriso -as mkisofs -R -r -J -joliet-long -l -cache-inodes -iso-level 3 -isohybrid-mbr /usr/lib/ISOLINUX/isohdpfx.bin -partition_offset 16 -A Debian Live -p live-build 1:20170920 binary.sh: 4: binary.sh: https://debian-live.alioth.debian.org/live-build -publisher Live: not found binary.sh: 4: binary.sh: https://debian-live.alioth.debian.org/: not found binary.sh: 4: binary.sh: [email protected] -V Debian: not found xorriso 1.4.6 : RockRidge filesystem manipulator, libburnia project. [...] --------------->8------------------- binary.sh, as generated by binary_iso, contains: ---------------8<------------------- # cat chroot/binary.sh #!/bin/sh mkdir -p binary/.disk echo "xorriso -as mkisofs -R -r -J -joliet-long -l -cache-inodes -iso-level 3 -isohybrid-mbr /usr/lib/ISOLINUX/isohdpfx.bin -partition_offset 16 -A "Debian Live" -p "live-build 1:20170920; https://debian-live.alioth.debian.org/live-build"; -publisher "Live Systems project; https://debian-live.alioth.debian.org/; [email protected]" -V "Debian stretch 20171116-20:52" --modification-date=2017111619114000 -b isolinux/isolinux.bin -c isolinux/boot.cat -no-emul-boot -boot-load-size 4 -boot-info-table -eltorito-alt-boot -e boot/grub/efi.img -no-emul-boot -isohybrid-gpt-basdat -isohybrid-apm-hfsplus -o live-image-amd64.hybrid.iso binary" > binary/.disk/mkisofs xorriso -as mkisofs -R -r -J -joliet-long -l -cache-inodes -iso-level 3 -isohybrid-mbr /usr/lib/ISOLINUX/isohdpfx.bin -partition_offset 16 -A "Debian Live" -p "live-build 1:20170920; https://debian-live.alioth.debian.org/live-build"; -publisher "Live Systems project; https://debian-live.alioth.debian.org/; [email protected]" -V "Debian stretch 20171116-20:52" --modification-date=2017111619114000 -b isolinux/isolinux.bin -c isolinux/boot.cat -no-emul-boot -boot-load-size 4 -boot-info-table -eltorito-alt-boot -e boot/grub/efi.img -no-emul-boot -isohybrid-gpt-basdat -isohybrid-apm-hfsplus -o live-image-amd64.hybrid.iso binary --------------->8------------------- As you can see, the pairs of quotes in the echo line don't match up as intended: echo "xorriso -as mkisofs -R -r -J -joliet-long -l -cache-inodes -iso-level \ ^--- open #1 [...] -partition_offset 16 -A "Debian Live" -p "live-build 1:20170920;[...] close #1 ---^ open#2--^ ^---close #2 \------------v------------/ interpreted by sh Subsequently, the generated .disk/mkisofs is empty. The attached patch moves the generation of .disk/mkisofs out of binary.sh and back to the enclosing binary_iso, replacing echo by a HERE document which is not prone to this kind of issue. With this patch applied, build.log no longer shows "not found" errors and the generated .disk/mkisofs contains: ---------------8<------------------- xorriso -as mkisofs -R -r -J -joliet-long -l -cache-inodes -iso-level 3 -isohybrid-mbr /usr/lib/ISOLINUX/isohdpfx.bin -partition_offset 16 -A "Debian Live" -p "live-build 1:20170920; https://debian-live.alioth.debian.org/live-build"; -publisher "Live Systems project; https://debian-live.alioth.debian.org/; [email protected]" -V "Debian stretch 20171116-21:12" --modification-date=2017111620114500 -b isolinux/isolinux.bin -c isolinux/boot.cat -no-emul-boot -boot-load-size 4 -boot-info-table -eltorito-alt-boot -e boot/grub/efi.img -no-emul-boot -isohybrid-gpt-basdat -isohybrid-apm-hfsplus -o live-image-amd64.hybrid.iso binary --------------->8------------------- Cheers Danieldiff --git a/scripts/build/binary_iso b/scripts/build/binary_iso index 6ddb9dd09..1ca460c02 100755 --- a/scripts/build/binary_iso +++ b/scripts/build/binary_iso @@ -214,7 +214,11 @@ fi cat >> binary.sh << EOF mkdir -p binary/.disk -echo "xorriso -as mkisofs ${XORRISO_OPTIONS} -o ${IMAGE} binary" > binary/.disk/mkisofs +xorriso -as mkisofs ${XORRISO_OPTIONS} -o ${IMAGE} binary +EOF + +# retain the xorriso command used to create the image in the image itself +cat <<-EOF >binary/.disk/mkisofs xorriso -as mkisofs ${XORRISO_OPTIONS} -o ${IMAGE} binary EOF
--- End Message ---
--- Begin Message ---Source: live-build Source-Version: 1:20171207 We believe that the bug you reported is fixed in the latest version of live-build, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Raphaël Hertzog <[email protected]> (supplier of updated live-build package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Thu, 07 Dec 2017 20:29:59 +0100 Source: live-build Binary: live-build Architecture: source Version: 1:20171207 Distribution: unstable Urgency: medium Maintainer: Debian Live <[email protected]> Changed-By: Raphaël Hertzog <[email protected]> Description: live-build - Live System Build Components Closes: 878430 879169 881941 Changes: live-build (1:20171207) unstable; urgency=medium . * Use $SOURCE_DATE_EPOCH when updating timestamps of manual pages in order to make the package reproducible at build time. Closes: #879169 Thanks to Chris Lamb <[email protected]> for the patch. * Accept kernels without initrd. Closes: #878430 Thanks to Balint Reczey <[email protected]> for the patch. * Fix the way the .disk/mkisofs file is created. Closes: #881941 Thanks to Daniel Reichelt <[email protected]> for the patch. Checksums-Sha1: 93578946f10e82657f39a0c8339e74baf23464f4 1384 live-build_20171207.dsc edbd56d52e77424679b586fcb509856d3a903832 354052 live-build_20171207.tar.xz e81544f466e8e3c0840572077a3e72fb2558b426 5258 live-build_20171207_source.buildinfo Checksums-Sha256: b18b5100b32c252dbab7943c6ee4c080943b752c57786bdad40085948a276dda 1384 live-build_20171207.dsc 523719e32b93011b32bd0102eb86f5d96b3f395808d751ba9bc4ff7b27152933 354052 live-build_20171207.tar.xz 8628591b9d41b5cdf29edfb2971b85b11eac42aedb272f78e2056665cb2ec0a7 5258 live-build_20171207_source.buildinfo Files: 91b44de1be8c9cd7e047b5c946cc0488 1384 misc optional live-build_20171207.dsc bf5b0ea9e6aaa75adc7a1a60fb9f987e 354052 misc optional live-build_20171207.tar.xz b962b8a245c8b604e512b519430a0bc6 5258 misc optional live-build_20171207_source.buildinfo -----BEGIN PGP SIGNATURE----- Comment: Signed by Raphael Hertzog iQEzBAEBCgAdFiEE1823g1EQnhJ1LsbSA4gdq+vCmrkFAloplt8ACgkQA4gdq+vC mrmLiggAusloDNbu1addjOb6+mtC6goQMzVoZX0f9KIDWsuMbEF6szLUn0KLuPoX Myv7T8OzntbpOJ4X1SCbQsUMw/7sP8l3gf1WFOtLWxU2MB0uo5GbgilGSIoODF8J TrJefTl78KtIXPcwvPgQLXTY4BrsX6V2wYelh+GCmKOHUj8gGyUb9P0t0KSxLm1P pEV0nWIPybTpsIz/g/ixBmyyiV97GMGvzND9048yKD/UPyb+mQcJhhcNlez5r6or zUmM/FfucB/ydDnYouPZh5s3gD2UpIquqVGx17+qyvOb7XYGTt5XBCT67QbpPrL0 fzIt7Tc8mTkQ9QzUw2+2167Xp7OEUg== =B1C1 -----END PGP SIGNATURE-----
--- End Message ---
