On 2015-12-29 07:36:30, Guido Günther wrote:
> Hi Thorsten,
>
> Isn't the logic reversed here? We want so _skip_ the header if it
> containsNonAlphaNumDash not add it?

After reviewing the patch, I agree, the logic is reversed.

I am also not sure why the patch is so different - did the primitives
change so much between the two versions that there's a new string type
and all?

Was the patch tested?

A.

-- 
A ballot is like a bullet. You don't throw your ballots until you see
a target, and if that target is not within your reach, keep your
ballot in your pocket.
                         - Malcom X

Reply via email to