Hugo Lefeuvre <h...@debian.org> writes:

>> ++        if (0xFFFFFFFF / tilew < spp) {
>
> I don't really like this patch... it has not been merged yet (the PR has
> been closed, so I guess it will never get merged) and looks more like a
> hack to me.
>
> What if tilew * spp = INT_MAX ?
>
> Then oskew + iskew will still overflow. So this does not fix the issue.

I can't say I really followed this patch... Seems odd using a divide
here. Should I skip this patch for now?
-- 
Brian May <b...@debian.org>

Reply via email to