Hello, I've prepared network-manager-iodine 1.2.0-3.2+deb12u1 for bookworm-security, and it's ready for review.
DSA-6629-1 shipped the fix in network-manager-iodine 1.2.0-3.3+deb13u1 in Trixie. network-manager-iodine 1.4.0-1 in Sid fixes CVE-2026-91837. The debdiff against 1.2.0-3.2 is attached, and so is the draft DLA. - CVE-2026-91837: https://gitlab.gnome.org/GNOME/network-manager-iodine/-/work_items/4 The three upstream commits are fe097bd0, f4872a68, and 8024e2ec. The fragment size sits with iodine's other options, a size is accepted from 1 to 65535, and the nameserver and the top domain are passed after an option separator. I built this in a Bookworm schroot. On a Bookworm virtual machine running kernel 6.1.0-54-amd64, I installed network-manager-iodine 1.2.0-3.2. A local user on seat0, allowed by NetworkManager to control the network and to modify that user's own connections, activated a connection whose nameserver was an iodine device option. The archive package ran the shell command from that device name as root before iodine dropped privileges, and wrote a root-owned file containing uid 0. With 1.2.0-3.2+deb12u1, iodine treated that value as a nameserver and the lookup failed. A connection with nameserver 127.0.0.1, top domain tunnel.example, and fragment size 1200 activated. The iodine command was "-f -u nm-iodine -t /var/run/nm-iodine -m 1200 -- 127.0.0.1 tunnel.example". Fragment sizes 1 and 65535 activated the same way. Fragment sizes 0, 65536, and a non-numeric value were rejected. A top domain that begins with a dash was rejected as a domain name. Here is my Salsa fork: https://salsa.debian.org/tsimonq2/network-manager-iodine/-/tree/debian/bookworm Here is the Debusine work request: https://debusine.debian.net/debian/developers/work-request/1624097/ Feedback is welcome. If nothing showstopping comes up, I'll upload this and issue the DLA on Friday morning (November 20th, 2026). Best regards, Simon Quigley [email protected]
diff -Nru network-manager-iodine-1.2.0/debian/changelog network-manager-iodine-1.2.0/debian/changelog --- network-manager-iodine-1.2.0/debian/changelog 2022-12-30 04:19:28.000000000 -0600 +++ network-manager-iodine-1.2.0/debian/changelog 2026-11-16 08:22:53.000000000 -0600 @@ -1,3 +1,13 @@ +network-manager-iodine (1.2.0-3.2+deb12u1) bookworm-security; urgency=high + + * Non-maintainer upload by the LTS Team. + * CVE-2026-91837: Place the fragment size with iodine's other options, + accept a fragment size only from 1 to 65535, and pass the nameserver + and the top domain to iodine after an option separator. + (Closes: #1148114) + + -- Simon Quigley <[email protected]> Mon, 16 Nov 2026 08:22:53 -0600 + network-manager-iodine (1.2.0-3.2) unstable; urgency=medium * Non-maintainer upload. diff -Nru network-manager-iodine-1.2.0/debian/patches/CVE-2026-91837-8024e2ec.patch network-manager-iodine-1.2.0/debian/patches/CVE-2026-91837-8024e2ec.patch --- network-manager-iodine-1.2.0/debian/patches/CVE-2026-91837-8024e2ec.patch 1969-12-31 18:00:00.000000000 -0600 +++ network-manager-iodine-1.2.0/debian/patches/CVE-2026-91837-8024e2ec.patch 2026-11-15 18:46:17.000000000 -0600 @@ -0,0 +1,32 @@ +Origin: backport, https://gitlab.gnome.org/GNOME/network-manager-iodine/-/commit/8024e2ecfbc1c9bee8ea0fb80c3358f77199d096 +Reviewed-by: Simon Quigley <[email protected]> +Last-Update: 2026-11-15 + +Backported to 1.2.0. The option separator is inserted after the +iodine options and before the nameserver and the top domain. + +From 8024e2ecfbc1c9bee8ea0fb80c3358f77199d096 Mon Sep 17 00:00:00 2001 +From: Guido Günther <[email protected]> +Date: Thu, 12 Nov 2026 08:04:28 +0100 +Subject: service: Use option separator + +This prevents domain names being treated as options + +Signed-off-by: Guido Günther <[email protected]> +--- + src/nm-iodine-service.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/src/nm-iodine-service.c b/src/nm-iodine-service.c +index 162fa0a..fa0ca6f 100644 +--- a/src/nm-iodine-service.c ++++ b/src/nm-iodine-service.c +@@ -476,6 +476,8 @@ nm_iodine_start_iodine_binary (NMIodinePlugin *plugin, + g_ptr_array_add (iodine_argv, (gpointer) props_fragsize); + } + ++ g_ptr_array_add (iodine_argv, (gpointer) "--"); ++ + if (props_nameserver && strlen(props_nameserver)) + g_ptr_array_add (iodine_argv, (gpointer) props_nameserver); + diff -Nru network-manager-iodine-1.2.0/debian/patches/CVE-2026-91837-f4872a68.patch network-manager-iodine-1.2.0/debian/patches/CVE-2026-91837-f4872a68.patch --- network-manager-iodine-1.2.0/debian/patches/CVE-2026-91837-f4872a68.patch 1969-12-31 18:00:00.000000000 -0600 +++ network-manager-iodine-1.2.0/debian/patches/CVE-2026-91837-f4872a68.patch 2026-11-15 18:04:41.000000000 -0600 @@ -0,0 +1,32 @@ +Origin: backport, https://gitlab.gnome.org/GNOME/network-manager-iodine/-/commit/f4872a68d3ce9d2259e3f1059d9c0bb3ad3deb76 +Reviewed-by: Simon Quigley <[email protected]> +Last-Update: 2026-11-15 + +Backported to 1.2.0. The fragment size becomes an integer from 1 to +65535, using the integer check already in this file. + +From f4872a68d3ce9d2259e3f1059d9c0bb3ad3deb76 Mon Sep 17 00:00:00 2001 +From: Guido Günther <[email protected]> +Date: Thu, 12 Nov 2026 08:16:18 +0100 +Subject: service: Validate fragsize + +We already have a validation for ints, use it + +Signed-off-by: Guido Günther <[email protected]> +--- + src/nm-iodine-service.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/nm-iodine-service.c b/src/nm-iodine-service.c +index 035c169..162fa0a 100644 +--- a/src/nm-iodine-service.c ++++ b/src/nm-iodine-service.c +@@ -81,7 +81,7 @@ typedef struct { + static ValidProperty valid_properties[] = { + { NM_IODINE_KEY_TOPDOMAIN, G_TYPE_STRING, 0, 0 }, + { NM_IODINE_KEY_NAMESERVER, G_TYPE_STRING, 0, 0 }, +- { NM_IODINE_KEY_FRAGSIZE, G_TYPE_STRING, 0, 0 }, ++ { NM_IODINE_KEY_FRAGSIZE, G_TYPE_INT, 1, 65535 }, + { NULL, G_TYPE_NONE, 0, 0 } + }; + diff -Nru network-manager-iodine-1.2.0/debian/patches/CVE-2026-91837-fe097bd0.patch network-manager-iodine-1.2.0/debian/patches/CVE-2026-91837-fe097bd0.patch --- network-manager-iodine-1.2.0/debian/patches/CVE-2026-91837-fe097bd0.patch 1969-12-31 18:00:00.000000000 -0600 +++ network-manager-iodine-1.2.0/debian/patches/CVE-2026-91837-fe097bd0.patch 2026-11-15 17:18:23.000000000 -0600 @@ -0,0 +1,45 @@ +Origin: backport, https://gitlab.gnome.org/GNOME/network-manager-iodine/-/commit/fe097bd0720c8dfd56df234e034cf4854c53bf5a +Reviewed-by: Simon Quigley <[email protected]> +Last-Update: 2026-11-15 + +Backported to 1.2.0. The fragment size moves to sit with the other +iodine options. + +From fe097bd0720c8dfd56df234e034cf4854c53bf5a Mon Sep 17 00:00:00 2001 +From: Guido Günther <[email protected]> +Date: Sat, 12 Sep 2026 14:10:32 +0200 +Subject: service: Move user controlled options together + +Signed-off-by: Guido Günther <[email protected]> +--- + src/nm-iodine-service.c | 10 +++++----- + 1 file changed, 5 insertions(+), 5 deletions(-) + +diff --git a/src/nm-iodine-service.c b/src/nm-iodine-service.c +index 89023d4..035c169 100644 +--- a/src/nm-iodine-service.c ++++ b/src/nm-iodine-service.c +@@ -459,11 +459,6 @@ nm_iodine_start_iodine_binary (NMIodinePlugin *plugin, + /* Run in foreground */ + g_ptr_array_add (iodine_argv, (gpointer) "-f"); + +- if (props_fragsize && strlen(props_fragsize)) { +- g_ptr_array_add (iodine_argv, (gpointer) "-m"); +- g_ptr_array_add (iodine_argv, (gpointer) props_fragsize); +- } +- + if (has_user(NM_IODINE_USER)) { + g_ptr_array_add (iodine_argv, (gpointer) "-u"); + g_ptr_array_add (iodine_argv, (gpointer) NM_IODINE_USER); +@@ -476,6 +471,11 @@ nm_iodine_start_iodine_binary (NMIodinePlugin *plugin, + } else + g_warning("Not running chrooted"); + ++ if (props_fragsize && strlen(props_fragsize)) { ++ g_ptr_array_add (iodine_argv, (gpointer) "-m"); ++ g_ptr_array_add (iodine_argv, (gpointer) props_fragsize); ++ } ++ + if (props_nameserver && strlen(props_nameserver)) + g_ptr_array_add (iodine_argv, (gpointer) props_nameserver); + diff -Nru network-manager-iodine-1.2.0/debian/patches/series network-manager-iodine-1.2.0/debian/patches/series --- network-manager-iodine-1.2.0/debian/patches/series 2022-12-30 04:19:21.000000000 -0600 +++ network-manager-iodine-1.2.0/debian/patches/series 2026-11-15 18:46:17.000000000 -0600 @@ -2,3 +2,6 @@ Let-dh-handle-any-autoreconf-configure-invocations.patch Install-appdata-into-metainfo.patch Use-full-path-to-auth-dialog-in-service-file.patch +CVE-2026-91837-fe097bd0.patch +CVE-2026-91837-f4872a68.patch +CVE-2026-91837-8024e2ec.patch
------------------------------------------------------------------------- Debian LTS Advisory DLA-XXXX-1 [email protected] https://www.debian.org/lts/security/ Simon Quigley November 20, 2026 https://wiki.debian.org/LTS ------------------------------------------------------------------------- Package : network-manager-iodine Version : 1.2.0-3.2+deb12u1 CVE ID : CVE-2026-91837 Debian Bug : 1148114 network-manager-iodine is the iodine VPN plugin for NetworkManager. A local user can run a command as root when this plugin is installed. CVE-2026-91837 The nameserver and the top domain are appended to iodine's command. iodine reads a value that begins with a dash as an option. On Linux the device name is copied into a shell command that runs before iodine drops root privileges. For Debian 12 bookworm, these problems have been fixed in version 1.2.0-3.2+deb12u1. We recommend that you upgrade your network-manager-iodine packages. For the detailed security status of network-manager-iodine please refer to its security tracker page at: https://security-tracker.debian.org/tracker/network-manager-iodine Further information about Debian LTS security advisories, how to apply these updates to your system, and frequently asked questions can be found at: https://wiki.debian.org/LTS
OpenPGP_signature.asc
Description: OpenPGP digital signature
