-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Nelson A. de Oliveira ha scritto: > Hi!
Hi :-) > David, your package fails to build: > > (...) > perl Makefile.PL INSTALLDIRS=vendor > Checking if your kit is complete... > Looks good > MakeMaker FATAL: prerequisites not found (Mail::Send not installed, > Parse::RecDescent not installed) > > Please install these modules first and rerun 'perl > Makefile.PL'. > make: *** [build] Error 2 > > Including libparse-recdescent-perl and libmailtools-perl on > Build-Depends fix this. I thought I had added those dependencies! Really! -.-' (looking at debian/control, I added them on Depends:, not on Build-Depends.) Fixed (dependency both on Depends: and Build-Depends:). > Still on debian/control. I think that it's not necessary the versioned > build-dep on perl, since we already have perl >= 5.6.0-16 since Sarge > (version 5.8.x). Unstable version is 5.8.8-7 Done. > Also, since it's a web application, shouldn't it depends, or at least > recommends, a HTTP server? > (README.Debian says "Visit http://localhost/cgi-bin/emboss to test > EMBOSS." but without a server we can't do this) Recommends "httpd" now. > Do it works without emboss? (has it some functionality that doesn't > need emboss?) I am asking this because emboss is just recommend (raise > to depends?) You're right, It's just an interface to EMBOSS. I'm raising to Depends. > And some (more) doubts on README.Debian: > How secure is to run the cron as root? Can't it be run with a less > privileged user? (if yes, then it's better on my opinion) Well, the cron removes files from /var/www/emboss/output. Usually, /var/www is property of www-data and, unless you add your user to www-data and give g+w recursively to the whole directory, you won't have right to do anything there. That's why _root_. Maybe, better, I can suggest to add that line to www-data's crontab. Suggestions? > These lines: > Please report any errors or strange occurrences using the bug tracker at > http://sourceforge.net/tracker/?func=add&group_id=124389&atid=699414 > > Can't they make the user think that he/she needs to report the bug to > the Emboss explorer BTS, even the ones related with Debian only? > (Could be possible to some users understand that they should report > _all_ bugs to the SF BTS, right?) > I would remove this line and let them report the issues directly to > the Debian BTS. If necessary, forward it to upstream authors. Deleted them :-) > You have repackaged the original source code, but it's not necessary to > do this. > Copy the debian/ dir inside emboss-explorer/, rename the original > emboss-explorer-2.2.0.tar.gz to emboss-explorer_2.2.0.orig.tar.gz and > you will see that the package will be built normally, without > problems. dpkg-source (if I remember correctly) can handle this, > without the need to add the version to the dir and create a new > .tar.gz file. I'll try then. I remembered that the top source dir must be named package-x.y.z. (isn't it a Policy requirement?) I'll give it a try though. ;-) > On debian/copyright you say that the program is released under the > Artistic License, but I see on README that it has the same terms of > Perl. > Perl's README says that it can be distributed under GNU GPL or under > the Artistic License. (needs to update the copyright file, like Perl's > copyright). Yes, I did see this. But on sf's page the author claims it's under Artistic License. Following README's directions, it should be distributed under both GPL and Artistic then. Changing debian/copyright to reflect this. > Maybe Charles can say something else, since he is the guy who plays > with Emboss :-) Maybe :-P The updated package has been uploaded to mentors (everything noticed in your mail has been fixed, but the crontab question. I'm waiting a reply from you for that). Thanks for your review :-) > Best regards, > Nelson Regards, David - -- . ''`. Debian packager! | http://snipurl.com/gofoxygo/ : :' : User #334216 | http://www.hanskalabs.net/ `. `'` GPG: 1392B174 | http://www.debianizzati.org/ `- 2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGRrlf5qqQFxOSsXQRAjOlAKCh6pgCW3tIWd2oGJRjPl1gT4VrNwCghl8F wCJkAEOm0BAYaSrE+sRRFIQ= =oTtc -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
