Hi, On Wed, Nov 26, 2008 at 02:46:45PM +0100, Andreas Hildebrandt wrote: > This is my first attempt at packaging, and comments would be very > welcome. Everything is checked into svn, package 'ball'.
I can only reiterate: This indirect calling of scripts in the build and install targets is ugly. Especially the install part - why don't you add this to your upstream build system if you maintain that as well? I.e., why do you remove the static libraries in the createBALLDeb script, instead of adding a switch/option to your upstream build system to not build the in the first place? Why does the upstream build system not install the files and documentation? Certainly one can do this in the Debian build system, but this is usually only a temporary band-aid until the upstream build system got fixed. Also, you seem to hardcode python2.5 in the createBALLDeb script, I think this is discouraged cause your packages will break once Debian switches its default python version and/or removes python2.5. cheers, Michael -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
