Thanks for your response, doing some benchmark tests sounds a good idea, which we will do.
Thanks, Daehwan On Tue, 2012-02-28 at 21:46 +0100, Andreas Tille wrote: > Hi Carlos, > > I think the patch is fine inside Debian (if not I would not have > uploaded the package) and also outside Debian I can not see any grave > problem in applying. There might be some slight issues regarding > optimisation of code on i386 machines - but finally you would need > to do some benchmark tests to verify the influence of this (my guess > would be it is not measurable - but I might be wrong). > > Kind regards > > Andreas. > > On Tue, Feb 28, 2012 at 03:34:41PM -0500, Carlos Borroto wrote: > > Hi Daehwan, > > > > Thanks for your answer. I have a very limited knowledge of C > > programming, so I won't be able to comment almost at all on this > > issue. From what I can tell, tophat builds just fine without this code > > in Debian, but you are correct to think that maybe is playing an > > important role on other systems. > > > > I'm copying Debian Med Project mailing list to see if someone else > > have any input on this issue. We could just use and maintain the > > simple patch provided by Peter in our package. > > > > Thanks for taking the time to look into it, > > Kind regards, > > Carlos > > > > On Tue, Feb 28, 2012 at 3:21 PM, Daehwan Kim <[email protected]> > > wrote: > > > Hi Carlos, > > > > > > We can remove that part that caused the incompatibility issues with > > > Debian, but I'm not sure whether or not the fix would create some other > > > issues in Mac or other linux variants. > > > > > > Thanks, > > > Daehwan > > > > > > > > > On Feb 23, 2012, at 5:08 PM, Carlos Borroto wrote: > > > > > >> Hi, > > >> > > >> I'm part of Debian Med's team. We built a TopHat package for Debian. > > >> The following bug report was submitted by Peter Green, Debian > > >> developer: > > >> > > >> "tophat: broken code in configure script for determining CFLAGS" > > >> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=660309 > > >> > > >> Peter also submitted this patch we chose to use in TopHat Debian's > > >> package: > > >> http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;filename=remove_crazy_cflag_code.patch;att=1;bug=660309 > > >> > > >> We would like to see if you can revisit this code and tackle Peter's > > >> concerns? > > >> > > >> Thanks, > > >> Kind regards, > > >> Carlos > > >> > > > > > > > > > -- > > To UNSUBSCRIBE, email to [email protected] > > with a subject of "unsubscribe". Trouble? Contact > > [email protected] > > Archive: > > http://lists.debian.org/cabgghb+9ogxfqcyofpunelyloehupnykk+wr_+bp9l75hi9...@mail.gmail.com > > > > > -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/1330611730.1759.81.camel@forephilo
