Sébastien, On Thu, Oct 4, 2012 at 4:02 PM, Sebastien Jodogne <[email protected]> wrote: > Salut Mathieu, > > Many thanks for your feedback. I have just uploaded a new version of the > Orthanc package: > http://mentors.debian.net/package/orthanc > http://mentors.debian.net/debian/pool/main/o/orthanc/orthanc_0.2.2-1.dsc
Much better indeed ! Some comments below: d/rules: * Why are you override_ing everything in d/rules ? Why not let dh decide what to do, where to compile ? Also cmake support --parallel (cf man dh) d/control: * why libcurl4-gnutls-dev | libcurl4-nss-dev | libcurl4-openssl-dev ? shouldn't that be something simplier like libcurl4-dev ? libcurl-dev ? libcurl-ssl-dev ? * do not use libpng12-dev, prefer the version less * no such thing as libdcmtk1-dev (>= 3.5) AFAIK * I would use debhelper >= 9; to get hardening working in cmake * Section: misc ? Really ? * libgtest-dev is listed but configure reveals: ... -- Could NOT find GTest (missing: GTEST_LIBRARY GTEST_MAIN_LIBRARY) ... * why use oflog and libwrap ? They are not used: ... dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/orthanc/usr/bin/orthanc was not linked against libwrap.so.0 (it uses none of the library's symbols) dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/orthanc/usr/bin/orthanc was not linked against liboflog.so.2 (it uses none of the library's symbols) ... d/orthanc.lintian-overrides * I: orthanc: unused-override spelling-error-in-binary usr/bin/orthanc negotation negotiation * what's wrong with sqlite in debian ? Which version exactly do you need ? ThirdPartyDownloads/jsoncpp-src-0.5.0.tar.gz * why convenient copy and not debian one: libjsoncpp-dev d/changelog: * just keep a single entry, with ref to ITP#. This is fine. d/copyright: * where is the copyright/license for jsoncpp, mongoose & sqlite-amalgamation ? * You need to explicitly state the license you are using for debian/* files. Something like "Same as above" is fine. d/compat: * use 9 d/orthanc.init: * /var/run is deprecated: http://wiki.debian.org/ReleaseGoals/RunDirectory Thanks ! -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/CA+7wUswyMTpV6+rnkUFywe+BokC2tdiBKmfaseKat=ovibq...@mail.gmail.com
