Your changes to libjung look great, thank you. I'm refreshing my blocker list for Trinity right now and will send that in another email.
On Fri, Aug 21, 2015 at 4:57 AM olivier sallou <[email protected]> wrote: > I suggest I take the package to update it (name, remove contrib ...) and > upload it, is that fine ? > After we should go on for trinity. I made local changes to patch it to > compile with gcc5 as well as a patch to compile with jung. > > Le ven. 21 août 2015 à 13:55, Michael R. Crusoe <[email protected]> a > écrit : > >> Yes, the package should use libcolt-free-java. You probably saw the nutty >> lengths I was going to to try to keep nonfree dependencies out. Should be a >> lot more straightforward now. >> >> On Fri, Aug 21, 2015, 04:29 olivier sallou <[email protected]> wrote: >> >>> hi Mickael, >>> I have a question regarding your packaging of libjung. >>> >>> I see that you copy some files in libjung-contrib (for algorithm and io): >>> >>> mv >>> jung-algorithms-2.0.1-sources/edu/uci/ics/jung/algorithms/importance/MarkovCentrality.java >>> \ >>> >>> jung-algorithms-2.0.1-sources/edu/uci/ics/jung/algorithms/importance/RandomWalkSTBetweenness.java >>> \ >>> >>> jung-algorithms-2.0.1-sources/edu/uci/ics/jung/algorithms/importance/RandomWalkBetweenness.java >>> \ >>> >>> jung-algorithms-contrib-2.0.1-sources/edu/uci/ics/jung/algorithms/importance/ >>> >>> >>> I had a quick look and those files looks the same than other ones (BSD >>> license). So why do you pout them in an other jar? >>> >>> If issue is related to colt, we can use libcolt-free-java, and in this >>> case keep all files together. >>> >>> Thanks >>> >>> Olivier >>> >>
