On Thu, Aug 27, 2015 at 11:44 PM Andreas Tille <[email protected]> wrote:
> Hi Michael, > > On Thu, Aug 27, 2015 at 08:44:29PM +0000, Michael Crusoe wrote: > > I don't know if it is allowed to have a Recommends on a package that > isn't > > in the archive yet, but rsem is ready for review. > > Thanks for your work on this. I fixed two minor issues (git pull). I'm > not sure what ID you want to use so please make sure Uploaders and > changelog owner are equal. > Fixed. > > > Note: more manpages may be needed; > > While I have dropped the createmanpages script (and moved it in SVN from > package_template to helper-scripts since it remains to frequently in > packages) this might be helpful to create some manpages using help2man. > However, we have other packages with a lack of manpages and I would not > insist on these. What I'm a bit more concerned about are the > manpage-has-bad-whatis-entry > lintian warnings. Do you see any chance to fix this with some post > editing of the pod2man result? > I've added a patch that patches the Perl scripts in question to add the whatis entries; debian/rules now runs pod2man during the build. The previously included pod2man files have been removed in favor of the build-time files. > > > I'd also like it to have a test as well > > (though the trinityrnaseq tests use rsem). > > I also like to see tests on every package where possible. I'd be fine > with uploading now to new and add the tests while the package is waiting > in new queue. > Thanks; ready for re-review & upload :-) > > Kind regards > > Andreas. > > -- > http://fam-tille.de > > -- Michael R. Crusoe: Programmer & Bioinformatician [email protected] The lab for Data Intensive Biology; University of California, Davis https://impactstory.org/MichaelRCrusoe http://twitter.com/biocrusoe
