On Thu, Aug 18, 2016 at 1:50 AM Sascha Steinbiss <[email protected]> wrote:
> Hi Michael, > > I took a look at hisat2: > Thanks! > > - I would add: > Copyright 1999, N. Jesper Larsson, all rights reserved. > from ls.h to d/copyright > Done > - IMHO d/rules should have a ‘clean' override that removes the man pages > built there > Already taken care of via dh_clean and d/clean: "debian/*.1" > - The watchfile doesn’t have any active entries? The following should > work: > opts=pasv \ > > ftp://ftp.ccb.jhu.edu/pub/infphilo/hisat2/downloads/hisat2-([0-9.]+)-source.zip > <ftp://ftp.ccb.jhu.edu/pub/infphilo/hisat2/downloads/hisat2-(%5B0-9.%5D+)-source.zip> Done, thanks! > > - The package does not build reproducibly for me — likely because I have > disorderfs enabled in my prebuilder setup, which is not the default. It > might help wrapping the $(wildcard …) lines in the Makefile with $(sort …) > etc. See https://reproducible-builds.org/docs/stable-inputs/. > Done, thanks for the tip. > > and python3-typed-ast: > > - Lintian still warns about the (easy to fix): > W: python3-typed-ast source: syntax-error-in-dep5-copyright line 25: > Continuation line outside a paragraph (maybe line 24 should be " .”). > - There are two license entries for ‘Files: *’ in d/copyright. From what > I can see, only typed_ast/ast27.py and typed_ast/ast35.py are Python > licensed, so it might be enough to set those two to License: Python, > keeping the rest as Apache 2.0? > I'm committed a clarification > - Since the package seems to be quite generic, it may be better > maintained with/in the DPMT [1]? What do you think? > I'm not familiar with that team's norms. I'm happy to hand it over after it is accepted. > > Cheers and thanks for working on these > Sascha > > [1] https://wiki.debian.org/Teams/PythonModulesTeam > > > > On 17 Aug 2016, at 16:56, Michael Crusoe <[email protected]> > wrote: > > > > Thanks! > > -- > > Michael R. Crusoe > > Community Engineer & Co-founder > > Common Workflow Language project > > https://impactstory.org/u/0000-0002-2961-9670 > > [email protected] > > +40 720 781 765 > > +1 480 627 9108 > > -- Michael R. Crusoe Community Engineer & Co-founder Common Workflow Language project https://impactstory.org/u/0000-0002-2961-9670 [email protected] +40 720 781 765 +1 480 627 9108
