Dear Andreas, On Fri, 29 Mar 2019 at 23:40, Andreas Tille <[email protected]> wrote:
> Dear Liubov, > > On Fri, Mar 29, 2019 at 07:09:18PM +0100, Liubov Chuprikova wrote: > > > > > > > All the tests are passing now :-) > > Cool! > > > For this package, there is one more run dependency: SINA [1][2]. Although > > it was not required > > for testing and strangely it is not mentioned in QIIME 2 tutorials as > well. > > Could we upload > > the plugin without SINA for the moment and add it later? Maybe it will be > > useful to leave > > a TODO message somewhere not to forget about SINA... > > Probably we can upload. We could have a look at sina first[3] > I have injected some rough packaging before I'll go to bed now. > Yeah, that's great! :-) I will take a look in a couple of days! With regards, Liubov Kind regards > > Andreas. > > > [1] https://github.com/epruesse/SINA > > [2] > > > https://github.com/qiime2/q2-alignment/blob/ed1d841cddfb47ce6e945d72c0ab106a2c3a6121/ci/recipe/meta.yaml#L26 > [3] https://salsa.debian.org/med-team/sina > > > -- > http://fam-tille.de >
