Hi, Andrius, On Thu, Apr 9, 2020 at 1:25 PM <[email protected]> wrote: > I gave your packaging a quick look, and here are my comments: > > 1. For DebianMed team-maintained packages debian/control should list the > DebianMed as the Maintainer, and you as the uploader. You may take chime > as example: > > https://salsa.debian.org/med-team/chime/-/blob/master/debian/control > > 2. debian/control misses Vcs-* items;
Fixed and pushed both above. > > 3. debian/copyright should list the upstream author as the copyright > holder, not the PyPA. As for the copyright years, development history of > recan could be checked (for example, via 'git log'). I forwarded the copyright statement issue to upstream [1]. I wrote this by following the LICENCE.txt of upstream repository. This seems upstream author's mistake, so forwarded. [1] https://github.com/babinyurii/recan/issues/14 Thanks for your review. Sincerely, Sao I Kuan [email protected]
