Am 11.02.21 um 17:23 schrieb Nilesh Patra:
> Hi Steffen,
>
> On Thu, 11 Feb 2021 at 20:48, Steffen Möller <[email protected]
> <mailto:[email protected]>> wrote:
>
>     Hello,
>
>     https://salsa.debian.org/med-team/bioawk
>     <https://salsa.debian.org/med-team/bioawk>
>
>
> I did the following:
>
> * Added autopkgtests (this has a bit of hard-coding in
> d/tests/run-unit-tests but it should probably be OK)
Great!
> * Added manpage for bioawk
Great!
> * Add d/u/metadata
The "---" as a first line to indicate the yaml - we do not do this for
d/control or so.  I do not mind, actually for d/u/edam I decided for the
"---" together with Matus, it should be mentioned on
https://wiki.debian.org/UpstreamMetadata if there is a consensus for this.
> * Added relevant hardening flags so that blhc passes.
Thanks! Is this no longer tested by lintian?
> * Enable salsa CI on the salsa repo
Lovely!
>
> Two questions:
>
> * Is the binary /usr/bin/maketab really needed? It doesn't seem to do
> anything useful in the overall bioawk functionality
I just skimmed through the source code - no, can go. Thanks!

> * Can I add my name to uploaders?

Please!

Thank you tons and - please upload.

Steffen

Reply via email to