On 8/4/21 11:49 PM, Shruti Sridhar wrote: > Hello! > > I have written autopkgtests for bamkit[1]
The python3-pysam should be in Depends field of d/control, it is not a test-only dependency And aw crap, this missing dependency will affect user experience :( I guess I'll push your changes also to next stable point release via p-u Thanks for adding tests Please also look at the minor changes I did > and ea-utils[2]. * Test data changed, updated and pushed * Lintian warning: "W: ea-utils source: globbing-patterns-out-of-order debian/tests/data/* debian/*" -- pushed a fix please run lintian yourself to fix this in future, both me and Andreas have asked you to do so earlier * Dropped useless B-D on r-cran-hmisc -- this *helps* gets it cross building as well * The CC variable had a mismatch, selecting the wrong cross compiler, fixed that to make it cross building * Lastly, I also sanitized the changelog a little, stuff like "Install docs", "Add get-test-data script" in the changelog is hard to parse for anyone who w/o explictily reviewing your changes, hence please write better changelog entires. Please take a look at my changes, let me know if you want to ask anything. Overall changes look good, thanks for adding tests! Nilesh
OpenPGP_signature
Description: OpenPGP digital signature
