Andreas Tille <[email protected]> wrote: >Hi Mohd, > >Am Wed, Apr 06, 2022 at 04:07:10PM -0000 schrieb Mohd Bilal: >> Hello team, >> >> I've added autopkgtest for bmtk[1] and would like someone to review >and sponsor my changes. > >Thanks a lot for your effort. > >> However I've some concerns. >> >> >https://salsa.debian.org/med-team/bmtk/-/tree/master/bmtk/simulator/filternet/lgnmodel/cell_metrics > has some csv files. >> But I cannot find these csv files in >/usr/lib/python3/dist-packages/bmtk/simulator/filternet/lgnmodel/ after >installing python3-bmtk. >> These csv's are required for the tests and I'm getting >FileNotFound Error[2] for these files when running the tests. > >I've added these csv files to the package now since it seems these are >necessary. > >> So as a workaround I've added a patch to skip this particular test >since I was unable to fix that test without the csv files. >> >> Can somebody review this and guide if this is not the right way to do it. > >I've not fully finished my review and need to go AFK now. May >be you have another look whether you can drop your patch now.
Thank you for your inputs. I've dropped my patch now and the autopkgtest now passes[1]. [1] - https://salsa.debian.org/med-team/bmtk/-/jobs/2650792 Regards, rmb > >Thanks again > > Andreas. > >> [1] - https://salsa.debian.org/med-team/bmtk >> [2] - https://salsa.debian.org/med-team/bmtk/-/jobs/2647435 >> >> Thanks & Regards, >> rmb > >> -----BEGIN PGP MESSAGE----- >> >> owGNU3tQVFUYXxbQurSIOj6mRA+jiSTLVR7qRFPxEHES05VJgxDO3nt297T3sZ5z >> dhemJrQx87FjIJoYSvUHGYyKqD3AHONhEY8eEo4zktYM4ZgoM6hjjDR17goNfzJz >> //ru9/2+3+M7ZZZQkxBy9sFB23sx1QtCToba7OFIhVix53x1Oxspig4Ygmq8IKyN >> 9SEAZRnJAHqZ7nE7GaIMOHQC7Cpz5y8vAFCTgV/3KjJQsBsBqqtI1xBgOiDIh5E/ >> 2EA9ukb5kFoCJBfUnIgmCEK27kc+REBwiTEHJF2TENGMny7GPPR5UaRQoTBBRnYM >> tQSdOEUVyVaDnWgQEK0iIwiJKqQMkcclilWvAplORAdWeFVDTFScmqrLSBElrq5Q >> RYxgiQIXpGN7qQ/wZoNVupeBtUCCmqZznZhzZy5EJ7QArAHRS4moYLvoKWEuXUsS >> ZUyZ1QMlN+TSJkEDQAcvcSjKoKJgzQnGkKzGbIKQO74zlgJIELdymxcTnoLhPCcE >> jBho0Nq1sSpwIsYMkCxOcL3OsnQv/7GaEJ3kJxaMz3DAxwL8LqQB4tU0Y+R/MO75 >> Jh1wRyDgeRI3JEGUiRcAPJBJLiNa6sYePoopLxGGJa6UBGEAxTxC7qCfI3k1aFeC >> p+DAxbwdsjHefszFcqON5RO8FzKgFgzErssl4+cT3GIIdXqxjAB2PK7wz0jIQCDY >> 6WJ8YYmxSdYBZhzKOE0rmNwVCYZLk23mJ/embqdi4orklclJKQLPCmpuChYDG3JC >> ItN4gah2YY85KcwUIpiiZ8eEWdE38xsdedrhESqMv7pws/HYTMKTUeMV1Bpl2r5t >> ZFPsOQu+oETUf+L607RmirnjxQ1Rdc+GjyYuuJIZ2X28/esPMm8ebTw9ciLKtjd3 >> /52Ky81hnkeDyandi2LaHwTCz9wz06Fwd0QLWDp1IG10Ws8TW/9uFWsdxa8+FXdd >> HarZ2XBcje5pzh3yKZvCKj8v7rHV1K0oXa4OR1XB/ANVvccG43vSW2C3LWLQ31Ez >> /FNd1u7Fp1Kf+35HZ+K/SW/0VlrbYsJbGtSBda5r0q6rz3w8NTfxeKFS9WvjrMWR >> ceduexdtfK33YldE2urik5FpncL2iFtLYt14z+Wq1hmuOVWp/UviUjK/KP8o7Lvz >> PZ05eb0JZYvu7V36cn+5r3j+9JX6tL7X8wKllV3TDlt29fdtLjx9Y97oxV96p/Zn >> vBWx/1rOP2fffueFnweKA3eXJV87YLlknp2QfiSy+X72nfcDv5XN/OyCWmMNaeoo >> 21s7OutM7XlLZ0dNq7mpW9q3Zs+R/PjqoXPO6LkPQ3f/8PTM7nfnzvEV7PzWdDDw >> FwnJ0vArW2+2P7xXBApmmPety2368XRf/IHBhRt/z6hurRi5Kn05UF9d82l5SqDh >> +h9bbFdODce1rZ9y6MPeykbvjhurjm2oX2bqyjnYvFkr7Z+V5rMUHTpR31RflDfY >> Zbk+ev+lhamnpHkVdYPDpUdbrm65e8Pi3JBGLg0HHkwP6TjZ8OjWqr6mVS0pbXPM >> /wE= >> =0vJv >> -----END PGP MESSAGE----- > >-- >http://fam-tille.de
