Hm, commenting out the dh_foo lines aren't against any policy, and many
packages do it - it's really just for reference in case they have to be
added later. There aren't any example debhelper files in the debian/
directory, only commented out lines in debian/rules. I know that
upstream should update the config.* files themselves, but 2.0.0 hasn't
been released since March and it's kind of pointless to put out a new
release just for minor changes to the autotools files. Looking at
configure.ac, it really only requires GTK+2 and pspell, so I just added
libgtk2.0-dev to the build-depends. I've removed debian/dirs completely,
since nothing needs it.
This package has the nice side effect that when LogJam (which has a
package in debian) reaches 3.1, it can be updated immediately while
including GtkSpell without waiting for these packages to be uploaded by
the logjam maintainer.
I've uploaded updated packages, not incrementing the revision since
nobody else really uses these yet.
Colin Walters wrote:
> On Tue, 2002-07-16 at 10:36, Ari Pollak wrote:
>
>>Yeah, I am registered as a New Maintainer, but the process takes a while
>>and I've been on "Waiting for DAM to approve blah blah" for more than a
>>month now. I'm registered under [EMAIL PROTECTED] I've uploaded
>>updated packages which close the ITP bug - I didn't increment the
>>revision, since that would seem pointless.
>
>
> That's fine. Actually, the first time I looked at your package, I only
> casually glanced through the Debian diff, and it looked ok. However,
> there are a few little things (and one big thing) that I noticed on a
> second pass.
>
> The major one is that your Build-Depends: are incorrect; at least
> libgtk2.0-dev is missing. To test this, I highly recommend using
> "pbuilder" to build your packages in a clean chroot. I often forget
> about this too, so don't sweat it :)
>
> The other little things are basically the same issues that Bastien
> Nocera raised in the thread "metacity-setup .debs" on debian-gtk-gnome;
> you have usr/sbin in the .dirs file, but don't actually put any files
> there. Also, I'd remove the commented out dh_foo lines from
> debian/rules.
>
> Finally, you are patching config.sub in your Debian diff; that's fine,
> but please push upstream to update it, so you don't have to.
>
> Thanks for making this package, it looks pretty neat. If you can fix
> these things I'll get it uploaded right away.
>
>
--
___ ___
/ _ | / _ \ Ari Pollak - [EMAIL PROTECTED] - www.aripollak.com
/ __ |/ ___/
/_/ |_/_/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
