control: owner -1 ! control: tags -1 moreinfo Hi, lets review!
rules: >-DCMAKE_BUILD_TYPE:STRING=Release please RelWithDebInfo here >override_dh_auto_test: # Don't run CTest please explain changelog: >Bug#780516 syntax error. bug: #780516 is right control: priority -> optional >Vcs-Git: git://anonscm.debian.org/debian-science/packages/toulbar2.git >Vcs-Browser: >http://anonscm.debian.org/gitweb/?p=debian-science/packages/toulbar2.git insecure vcs, deprecated gitweb (cgit now) >Standards-Version: 3.9.6 3.9.7 now >Architecture: amd64 i386 why? copyright: please convert in machine-readable format 1.0 https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ (mostly done, but some bits are missing) " Copyright (c) 2008 Olivier ROUSSEL (olivier.roussel <at> cril.univ-artois.fr " not mentioned in copyright file. missing licenses: src/SimpleGlob.h: *No copyright* MIT/X11 (BSD like) src/xmlcsp/XMLParser_libxml2.hh: MIT/X11 (BSD like) src/xmlcsp/XMLParser_constants.h: MIT/X11 (BSD like) src/xmlcsp/XMLParser.hh: MIT/X11 (BSD like) src/xmlcsp/ExpressionParser.hh: MIT/X11 (BSD like) src/xmlcsp/CostRepresentation.hh: MIT/X11 (BSD like) src/xmlcsp/C_AST.h: MIT/X11 (BSD like) src/xmlcsp/CSPParserCallback.hh: MIT/X11 (BSD like) src/xmlcsp/AST.hh: MIT/X11 (BSD like) check-all-the-things review: codespell --quiet-level=3 cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.' fdupes -q -r . | grep -vE '/(\.(git|svn|bzr|hg|sgdrawer)|_(darcs|FOSSIL_)|CVS)(/|$)' | cat -s grep -Er '/(home|srv|opt)(\W|$)' . flawfinder -Q -c . # You should almost never use -m64 and -m32 when compiling. $ grep -rE -- '-m64|-m32' . $ perlcritic -1 . 2>&1 | grep -vF 'No perl files were found.' $ find -type f \( -iname '*.pl' -o -iname '*.pm' \) -exec podlint {} \; $ find -type f -iname '*.sh' -exec sh -n {} \; grep -riE 'fixme|todo|hack|xxx' . Please add some upstream metadata: https://wiki.debian.org/UpstreamMetadata I don't expect everything to be fixed, but please check my review and comment on the above points. I didn't check lintian or to run the package, I'll do as soon as the above is addressed/commented. cheers, Gianfranco
