Thanks a lot for the review, I've fixed the license issues, libs and build deps. New uploaded version should appear on mentors in no time.
The code with `make dist' and `mk-orig-source' is a fossil from first packaging attempt (trying to get both GBP and development in one repo). Now the package repo is a separate, "completely normal" gbp with import-orig's here: https://github.com/exaexa/codecrypt-debian (relevant discussion can be found on pkg-privacy ML on alioth). Best regards and thanks again. -mk On Mon, 4 Apr 2016 at 21:05 Gianfranco Costamagna <[email protected]> wrote: > control: owner -1 ! > control: tags -1 moreinfo > > Hi, lets review: > > control: > autotools-dev, dh-autoreconf, > > I think autoreconf alone should be enough. > > libgmp10, libcrypto++9v5, libfftw3-double3 > > on noes! shlibs:Depends should do that automatically. If not, it means > your binaries are not > linking correctly the library from the development package in > build-dependencies. > > Please remove and test a built deb file under section debian/control to > see how they were substituted. > > copyright: license is wrong. > (licensecheck is a good help) > > > rules: > $(DEB_SOURCE)-$(DEB_VERSION_UPSTREAM).tar.gz: > $(MAKE) dist > > .PHONY: mk-orig-source > mk-orig-source: $(DEB_SOURCE)-$(DEB_VERSION_UPSTREAM).tar.gz > ln -f "$<" ../$(DEB_SOURCE)_$(DEB_VERSION_UPSTREAM).orig.tar.gz > > > why? you already use uscan and uupdate to download the tarball, why is the > above code useful? > > other stuff LGTM > > cheers > G. > >
