Hi, Thanks again for your review. I've uploaded a new version. Some comments below:
Le vendredi 15 avril 2016 à 13:38 +0000, Gianfranco Costamagna a écrit : > Hi again, > > > > > There is only one binary which is installed with 'dh_install' > > Upstream's 'make install' installs the binary in '/usr/local/bin' > > export prefix=/usr works in rules? > > I see this in makefile > "prefix ?= /usr/local" > > (I didn't test the above) Fixed, thanks for the trick > > > > Missing authors are from 'erlang.mk' which is the external build > > system. I suppose nobody would include autotools authors, for > > instance, > > even if m4 macros, or generated configure is included in the > > package, > > isn't it ? > > I usually prefer to list them, even if actually not strictly required > by > > ftpmasters. > (but I agree, autotools and erlang are generic files, so you can also > forget to list them) > I've included all copyrights. > > > > Hard-coded paths are only in unit tests, for testing path > > transformation functions. > > ok > > http://debomatic-amd64.debian.net/distribution#unstable/averell/1.2.5 > -1/buildlog > > FTBFS, please fix. > Should be fixed, were missing some build deps. Tested with pbuilder. > > g. -- Jean Parpaillon -- Open Source Consultant Director @ OW2 Consortium OCCIware Strategic Orientation Committee Chairman Research Engineer @ Inria -- Phone: +33 6 30 10 92 86 im: [email protected] skype: jean.parpaillon linkedin: http://www.linkedin.com/in/jeanparpaillon/en
