control: tag -1 +confirmed -moreinfo control: noowner -1 Hello,
On Thu, Jun 23, 2016 at 04:07:21PM +0300, Dmitry Bogatov wrote:
> > 2. I noticed with all of your packages that I reviewed that there is no
> > trailing newline at the end of your files. My Emacs keeps trying to
> > add it... is there some reason for this? Obviously not a blocker for
> > sponsorship.
>
> Bad habit. Sorry.
Enjoy:
;; require a buffer to have a final newline
(setq require-final-newline 'visit-save)
> > 3. Any particular reason you are using gz and not xz compression in
> > gbp.conf? Also, it might be a good idea to check the tarball into
> > git with pristine-tar so that a sponsor has exactly the same one (I
> > generated my own for testing).
>
> None. Just cut-and-yank from paredit package.
Okay. I'd be grateful if you could use dh-make-elpa and report bugs,
although it's having trouble with gbp.conf right now I think.
> > 4. Please add a d/watch file.
>
> Need help with it. No idea how to track versions on Emacs wiki.
Ah, yes. I don't think it can be done because I don't think uscan can
extract the version from the contents of the file: it needs the URL of
the wiki page to change with each version and that's not going to
happen. I think we have to abandon this goal.
> We probably need to make emacsen policy more... verbose.
I agree. Please feel free to edit the team ikiwiki.
--
Sean Whitton
signature.asc
Description: PGP signature
