Hi Gianfranco,
good to hear from you! Many thanks for your feedback.
control:
> description should be extended a lot
Have made the descriptions more meaningful
> some build-dependencies might be useless, did you check that? e.g.
dh-buildinfo
> intltool (note: I'm not checking the above)
> "python2.7" <-- what?
> don't see any Python script here, and I see only
> ./panel/manager.vala: engine.enable_loader("python3");
Good spot - this was a left-over from 6 months ago when git compiling was
done. This has been tidied.
rules:
> please use the new dh sequencer.
Ok - TL;DR; from stuff I was discussing with Paul Wise. Budgie-Desktop is
definitely not Debian deb-helper friendly. With a standard v9 debhelper -
even with a override_autoreconf, override_autoreconfigure etc, it appears
from first glance that the compilation works. However on installation the
budgie-session fails to launch. I discussed this upstream but could not
find a resolution.
The recipe you see is basically the older deb packaging style - but more
importantly works in Debian Stretch 32bit & 64bit (tested regularly over
the last 6 months), developed from Ubuntu 15.10 and reused for 16.04 and
16.10 (again 32bit and 64bit).
Sorry - I cannot find a new style debhelper recipe that works against all
target platforms
install files:
> usr/lib/libbudgietheme*.0
> this might be something like:
> usr/lib/libbudgietheme*.so.*
Agreed - fixed.
> maybe?
> lintian overrides? please remove and fix bugs, or comment about why
> you think lintian is wrong
>this is all for a first review.
budgie-core binary: desktop-entry-contains-unknown-key * --> This is
because budgie-desktop introduced its own unique key "Budgie" - the desktop
autostart for network manager and each of the budgie executables use this
key to ensure the executables only launch for budgie-desktop and therefore
have no impact on people using multiple desktop environments.
happy to remove the override if required.
On 29 June 2016 at 10:57, Gianfranco Costamagna <[email protected]>
wrote:
> control: owner -1 !
> control: tags-1 moreinfo
>
> Hi,
>
> control:
>
> description should be extended a lot
> some build-dependencies might be useless, did you check that? e.g.
> dh-buildinfo
> intltool (note: I'm not checking the above)
>
> "python2.7" <-- what?
>
> I don't see any Python script here, and I see only
> ./panel/manager.vala: engine.enable_loader("python3");
>
>
>
> rules:
> please use the new dh sequencer.
>
> install files:
> usr/lib/libbudgietheme*.0
>
> this might be something like:
> usr/lib/libbudgietheme*.so.*
>
> maybe?
>
> lintian overrides? please remove and fix bugs, or comment about why
>
> you think lintian is wrong
>
> this is all for a first review.
>
> G.
>
