On 09/15/2016 10:02 AM, Ghislain Vaillant wrote: > On 15/09/16 08:53, Gianfranco Costamagna wrote: >>> I know this approach >>> works, but is it the "right" way? Does it matter? >> >> your way is the best one if you also add a patch to automatically >> install the file >> inside the upstream build system. >> >> Otherwise you can avoid a patch and add the desktop file inside the >> debian directory, >> and ask upstream to integrate it. > > In my personal experience, upstream usually prefers to be asked about > where to put the .desktop file. So writing a patch that blindly places > it in the root of the source tree may be rejected as is. > > Instead you should rather first embed it in the debian/ folder and > discuss with upstream where to put it in a subsequent PR.
A desktop file without application icons doesn't make a lot of sense, placing the desktop relative to icons is common. Related policy: https://www.debian.org/doc/debian-policy/ch-opersys.html#s-menus Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
