在 2016年11月13日星期日 CST 下午2:43:47，Sean Whitton 写道： > plus some other minor comments below. The blocker: > > hephaestus ~ % nixnote2 > QSqlDatabase: QSQLITE driver not loaded > QSqlDatabase: available drivers: QMYSQL3 QMYSQL > ERROR 2016-11-13 14:38:58.946 ( sql/databaseconnection.cpp @ 44 ) Error > opening database: QSqlError(-1, "Driver not loaded", "Driver not loaded") > > Any ideas?
A missing dependency libqt4-sql-sqlite caused this problem. It seems that
the automatic dh_shlibdeps failed to list it inside Depends list (it only
listed libqt4-sql). A explicit dependency was added the latest commit.
> > * Some minor modification to package description in debian/control.
>
> 1. There's a grammatical error in your change: s/provide/provides/.
>
> 2. The sentence doesn't really make sense. Maybe s/and/to/ is what you
> meant?
Fixed.
> > * Copyright information update for beta10 version.
>
> 3. Are you installing the plugins at present, 'hunspell' and 'webcam'?
> Contents of package suggests not. Upstream seems to think they belong
> in separate binary packages. What do you think about that?
Added debian/README.Debian file to explain the situation. The plugin structure
won't support Qt5, plus upstream placed the plugin inside /usr/share, which is
not acceptable. The building system (CMake) for plugins is not in standard
status, too. My choice is not to install the plugins and wait until upstream
provides with a better solution.
Patching may be possible but that would be painful.
> > Blhc on debomatic reported some missing CXXFLAGS (-fPIE). However
> > since new gcc has already set -fPIE by default since 6.2.0-7, this
> > should be harmless.
>
> Yes. Lintian would be complaining if it wasn't being passed.
Again this needs patching, so I would choose to look into it later until some
real problem comes up.
> 4. I'm curious why you nuked gbp.conf. Entirely up to you, of course.
I found git-buildpackage not reading the "debian/gbp.conf" at all unless I
list it explicitly inside environment variable, which is different from words
written in man 5 gbp.conf. Command line arguments should be a better choice
for me.
> 5. Your Forwarded: headers got eaten at some point. Would be nice to
> restore them.
Well it is a problem hiding in gbp pq, which will eat non-mandatory headers
when exporting patches because git commit does not preserve those information.
Maybe I fill file a bug report (feature request?) later.
> 6. You could install the new screenshot.png to
> /usr/share/doc/nixnote2/examples (see dh_installexamples(1)).
Done.
Git repository updated on
https://anonscm.debian.org/git/collab-maint/nixnote2.git
Package on debian-mentors updated:
https://mentors.debian.net/package/nixnote2
Package built on debomatic:
http://debomatic-amd64.debian.net/distribution#unstable/
nixnote2/2.0~beta10+dfsg-1/
Sincerely,
Boyuan Yang
signature.asc
Description: This is a digitally signed message part.
