Hi Janusz, On Tue, Dec 26, 2017 at 06:53:39PM +0100, Janusz Dobrowolski wrote: > Hi Tobi, > > Thanks for the review. I have fixed most of the issues you have pointed out. > One thing I could not address yet is declared debhelper compatibility > level. My current development box runs Ubuntu 14.04, and for some reason > I could not successfully compile the package using gbp buildpackage in > pbuilder environment. I will have to investigate it further.
You definitely should not build for Debian in Ubuntu. At least, debootstrap a Debian chroot and build from there, but bulding from Ubuntu calls for trouble. You will also not have a recent toolchain with that old Ubuntu, so there is so much stuff that you will miss... > Anyway, I have pushed fixed package version to mentors.debian.net, and > one additional warning appeared. While the latest published Debian > standards specification seems to be 4.1.2.0, lintian check section on > mentors frontaccounting package page shows now new-standards-version > warning. This appeared after advised change in the SV field from > previous 3.9.8, so I guess it is just false positive due to not up to > date lintian version on mentors.debian.net? Exactly, mentors runs an older version. > Regarding old bug reports on BTS, I have resolved all that marked +rm > already. I will make also a review of the rest old closed bugs, but as > far as I know most of them are already fixed in current package. The bugs I see on the BTS are all "Done". This is wrong... Looking at #717031 as an example: You did reopen it but you have marked it fixed afterwards. Don't do that. Bugs must be closed using the changelog. -- tobi > Janusz > > On 25.12.2017 20:11, Tobias Frost wrote: > > Control: tags -1 moreinfo > > > > Hi Janusz, > > > > I've seen that you've uploaded a new pacakge to mentors... > > (would be great if you could that announce that on the bug too, so > > people now that its time to take a look)... > > > > (I've some time to spend to review packages, but I won't be able to do > > a complete review. Sorry, I do not plan to sponsor this pacakge) > > > > - Please drop d/README.source, using quilt is standard. > > - You do not close the ITP in the changelog, stating the reintroduction > > as reason, > > - d/compat is level 9, you want 11. > > - d/control: > > - You do not need to B-D on quilt > > - SV is out of date > > - lots of trailing whitespaces. wrap-and-sort might help. > > - d/copyright: License short specifieer "GPL-3" is actually "GPL-3+" > > Same with the LGPL -> LPGL-2.1+ ? > > - please modernize d/rules (short debhelper format?) > > > > - You probably want to unarchive and reopen the bugs you gonna close > > and also check the other bugs (if any) if they are still applicable and > > reopen them too. (This procedure is listed in the link pabs showed you) > > > > Please remove the moreinfo tag once you're ready for another round of > > review! > > > > -- > > tobi > > > >
