On Fri, 2018-02-09 at 07:31 +0100, Maxime Werlen wrote:

> Thanks for your time reviewing this package.

Thanks for adopting urlwatch :)

> I've tried to fix as much issues as I'm capable.

Excellent.

Since you fixed the two blockers, I've uploaded it to NEW.

A few more things that might be nice to fix at some point:

The example file gets compressed in the package, I wonder if it would
be better for it to be uncompressed or not.

The ISC license in debian/copyright is missing the blank line that is
in minidb.py. Please note that blank lines are encoded in Debian
copyright as lines " ." (space followed by a dot and then newline).

I would wrap the watch file between the URL and regex too.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to