Useful review bro I will be follow guideline.
Thanks you so much. On Tue, May 22, 2018, 2:54 PM Boyuan Yang <[email protected]> wrote: > Control: tag -1 + moreinfo > > On Fri, 18 May 2018 10:57:41 +0630 kokoye2007 <[email protected]> > wrote: > > Package: sponsorship-requests > > Severity: wishlist > > > > Dear Maintainer, Developer and Contributor > > > > I am looking for a sponsor for my package "fonts-myanmar" > > > > * Package name : fonts-myanmar > > Version : 1.0-1 > > Upstream Author : kokoye2007 <[email protected]> > > * URL : > https://salsa.debian.org/kokoye2007-guest/font-myanmar > > * License : gpl2 > > Section : fonts > > > > It builds those binary packages: > > > > fonts-myanmar - ttf myanmar fonts: > > fonts-myanmar-angoun - myanmar fonts: angoun; > > fonts-myanmar-ayar - ttf myanmar fonts: ayar; > > fonts-myanmar-chatu - myanmar fonts: chatu; > > fonts-myanmar-chatulight - myanmar fonts: chatulight; > > fonts-myanmar-gantgaw - myanmar fonts: gantgaw; > > fonts-myanmar-khyay - myanmar fonts: khyay; > > fonts-myanmar-kuttar - myanmar fonts: kuttar; > > fonts-myanmar-mon - myanmar fonts: MON3 Anonta 1 ; > > fonts-myanmar-myanmar3 - ttf myanmar fonts: Myanmar3; > > fonts-myanmar-myanmarcensus - ttf myanmar fonts: MyanmarCensus; > > fonts-myanmar-myanmarsanspro - myanmar fonts: Myanmar Sans Pro; > > fonts-myanmar-namkhome - myanmar fonts: Namkhone; > > fonts-myanmar-nayone - myanmar fonts: nayone; > > fonts-myanmar-njaun - myanmar fonts: njaun; > > fonts-myanmar-pauklay - myanmar fonts: pauklay; > > fonts-myanmar-phetsot - myanmar fonts: phetsot; > > fonts-myanmar-phiksel - myanmar fonts: phiksel; > > fonts-myanmar-phikselsmooth - myanmar fonts: phikselsmooth; > > fonts-myanmar-ponenyet - myanmar fonts: ponenyet; > > fonts-myanmar-pyidaungsu - ttf myanmar fonts: Pyidaungsu; > > fonts-myanmar-sabae - myanmar fonts: sabae; > > fonts-myanmar-sagar - myanmar fonts: sagar; > > fonts-myanmar-sanpya - myanmar fonts: sanpya; > > fonts-myanmar-squarelight - myanmar fonts: squarelight; > > fonts-myanmar-tagu - myanmar fonts: tagu; > > fonts-myanmar-thuriya - myanmar fonts: thuriya; > > fonts-myanmar-unicode - ttf myanmar unicode fonts > > fonts-myanmar-waso - myanmar fonts: waso; > > fonts-myanmar-yinmar - myanmar fonts: yinmar; > > fonts-myanmar-zawgyi - ttf myanmar fonts: ZawgyiOne2008; > > > > To access further information about this package, please visit the > following URL: > > > > https://mentors.debian.net/package/fonts-myanmar > > > > > > Alternatively, one can download the package with dget using this > command: > > > > dget -x https://mentors.debian.net/debian/pool/main/f/fonts-myanmar/ > fonts-myanmar_1.0-1.dsc > <https://mentors.debian.net/debian/pool/main/f/fonts-myanmar/fonts-myanmar_1.0-1.dsc> > > > > more info or old launchpad ppa at > > launchpad.net/ttf-myanmar-fonts > > > https://code.launchpad.net/~kokoye2007/ttf-burmese-fonts/font-myanmar > > Hi kokoye, > > First of all, I am not a Debian Developer thus I will not be able to > sponsor > your package. However, I come to make some reviews here: > > Fonts packaging may not be trivial. I still strongly suggest that you seek > help from Debian Fonts Team first for best practice in font packaging. > > As for the packaging itself, there are several critical and non-critical > problems. I will list them according to their severities: > > * I could not find any sign of font "source" (or its original form) even > though you gave a link to a launchpad.net project. The project source > looks > not the same as the tarball you distributed. The authorship information is > not > clear, too. Please contact Debian Fonts Team for suggestions. > > * Package description in debian/control file is not acceptable. As per the > requirement in Debian Policy [2] (please read that section in Debian > Policy > again), you should describe the package clearly in plain English > sentences, > not in disjointed English words. Mentioning PPA is also totally > unnecessary. > > * Files in debian/patches/ are not taken care well. They are largely patch > templates and metadata are not filled in at all. Patch names are also > confusing and could not reflect their purposes. Please follow the Patch > Tagging Guidelines [3] and fix them accordingly. Besides, you should be > explicit about why you are adding those files as patches. At least I could > not > find out where those texts came out from. > > * Where does the version string "1.0-1" come from? Where is the upstream > "1.0" > release? I could not find it in that launchpad project you referenced. > > * License information in debian/copyright seems to indicate that file > "ZawgyiOne2008.ttf" is completely non-free (even if you wrote literally > "FREE" > in its license field). What is exactly its author and in what license did > they > release it? Is there any upstream website or upstream statement for it? > (If > there's any, please reference them.) Please recheck and update debian/ > copyright information again. > > * You are required to paste full OFL-1.1 license text into > debian/copyright > file. > > * Using "LGPL" as the name for "LGPL 3.0" license is not recommended. > Please > add version string inside license name as stated in [4]. > > * Please bump your debhelper compat version to v11, together with > debhelper > version requirement in debian/control file. > > Please at least fix the first five issues here that I consider "critical" > to > uploading this package into Debian or please give proper explanations. It > will > be better if other issues are fixed too. > > -- > Regards, > Boyuan Yang > > > > [2] https://www.debian.org/doc/debian-policy/#the-description-of-a-package > [3] http://dep.debian.net/deps/dep3/ > [4] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
