Hi Chris, Thank you for sponsoring and reviewing! Reply follows inline.
On Thu, Aug 09, 2018 at 08:06:43AM +0100, Chris Lamb wrote:
> For your wishlist/TODO:
>
> * Please fix "wrong-section-according-to-package-name" on your next
> upload (or otherwise fix Lintian).
This is currently an Informational level message. When it was a
Warning I declared Section: lisp, even though I do not believe that
this is accurate.
Re: fixing Lintian, this will require a discussion and a more clear
definition of Section: lisp. Most Emacs modes should probably be in
Section: editors, because they are interactive extensions to an
editor. Magit is definitely in the right section eg: vcs. Emacs
packages that enable IDE modes should be in Section: devel.
Section: lisp should be reserved for libraries like dash-el.
> * You should probably avoid building the documentation too if the
> nodocs build profile is enabled.
I've added it to my TODO and will start learning about how to do
this.
> * gzip -9 might need to be gzip -9n for a reproducible build
> (unchecked) but I'm surprised it's not compressed by another tool
> too (unchecked).
Thank you for pointing this out. I've reverted @commit:9095c18
because README.rst is only 2.8k and dh_compress already does the
right thing automatically; that is to say, README.rst is not
"larger than 4k in size" and should not be compressed.
On the topic of reproducibility, generating an info page made Elpy
unreproducible!
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/elpy.html
This will take time to look into. Possibilities are:
1) sphinx-build is at fault
2) makeinfo is at fault
3) something is missing how I'm using 1 and/or 2.
- if this is the case then it's also a case of incomplete
documentation
Sincerely,
Nicholas
signature.asc
Description: PGP signature
