On Sun, Apr 14, 2019 at 10:25:55AM +0200, Birger Schacht wrote:
>
> * Package name : errbot
> Version : 6.0+ds-1
> It builds those binary packages:
>
> * errbot
Hi!
In the .service file, you use LC_ALL=en_US.UTF-8 unconditionally. That
won't work for anyone who's doesn't have that locale generated. Besides
USians, many people whose native language is not English use that as
fallback (it's d-i's default in such cases), but Brits, Aussies and the like
will have en_{UK,AU}.UTF-8 instead. The only guaranteed locale is C.UTF-8.
Very likely that'd be enough for you -- but if not, you'd need to organize
a way to run the daemon with a privately generated locale.
Also, why .service instead of an init script? This makes the daemon work
only with systemd -- not with sysv-rc, openrc, runit, etc. In particular,
this means that _I_ can't (without extra effort) test this package.
Of the following combinations:
* .service, no init
* both .service and init
* init, no .service
the latter two work everywhere; the last one being least work.
Everything else about the package seems to be ok.
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢰⠒⠀⣿⡁
⢿⡄⠘⠷⠚⠋⠀ At least spammers get it right: "Hello beautiful!".
⠈⠳⣄⠀⠀⠀⠀
