On Wed, Jun 05, 01:40, Adam Borowski wrote > On Tue, Jun 04, 2019 at 05:06:00PM +0200, Andre Noll wrote: > > v3 is pushed out now and contains > > a simple debian/rules file which fully relies on dh. Besides > > dh_auto_configure I also had to override dh_autoreconf for reasons > > explained in the commit message. > > The package looks almost good now. You do close a completely unrelated ITP > bug though: "ITP: eazel-engine".
That's the old hen and egg problem: One needs to provide a bug number
in debian/changelog for the initial RFS, i.e. before the bug has been
opened. So I put a dummy number there and forgot to update it after
the bug number had been assigned. Fixed now.
> On the other hand, the package neither ships any data files, nor can't
> handle their lack gracefully: it crashes with:
> regfile_iter_new: opendir /home/kilobyte/.tfortune/epigrams: No such file or
> directory
I'd argue that this is not a crash but a graceful exit due to a fatal
error :)
But yeah, the error message could be more user-friendly. We could
make it print something like
fatal: could not open epigram directory
and a similar message for the tag expression directory. Alternatively,
tfortune could create the two directories at startup. What do you
think?
Best
Andre
--
Max Planck Institute for Developmental Biology
Max-Planck-Ring 5, 72076 Tübingen, Germany. Phone: (+49) 7071 601 829
http://people.tuebingen.mpg.de/maan/
signature.asc
Description: PGP signature
