Control: owner -1 ! Control: tag -1 moreinfo On Sun, May 31, 2020 at 02:33:33PM +0000, Vasyl Gello wrote: > dget -x > https://mentors.debian.net/debian/pool/main/s/shairplay/shairplay_0.9.0+git20180824-1.dsc
* d/control:
+ vcs is set to your private space, but the package is team maintained
+ why did you decide to use "shairplay-bin" instead of just
"shairplay"?
+ drop the full stops from the synopsis (lintian flags this, didn't you
see it?)
* d/changelog:
+ it's not closing an ITP
* d/libshairplay-dev.install:
+ same as the other pacakge regarding the .a file.
* d/shairplay-bin.install:
+ imho, you could just reduce the line length with "usr/bin" and
"usr/share/man" without specifying the single files, since there is
no risk here to pick up stuff from other binary packages accidentally
* d/rules:
+ beware of what that dh_installdocs call you did actually do. I
believe you don't want that. hint: check the package contents.
+ you are -X'ing the .la file in dh_install? is that really needed?
+ same as the other package regarding dh_missing.
* d/patches:
+ did you forward them? if you did please add some headers following
DEP-3.
* d/watch:
+ since now uscan supports scanning bare git repositories, I think you
should add a watchfile novertheless
Incidentally, the git repository and what you uploaded to mentors are
slightly different:
|--- shairplay-0.9.0+git20180824/debian/control 2020-05-31 02:00:00.000000000
+0200
|+++ shairplay-0.9.0+git20180824/debian/control 2020-05-31 02:00:00.000000000
+0200
|@@ -34,7 +34,7 @@
| .
| Currently only AirPort Express emulation is supported.
| .
|- This package installs the shairplay server executable
|+ This package installs the shairplay server executable.
|
| Package: libshairplay-dev
| Architecture: any
:P
NOTE: I haven't reviewd the copyright yet.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
More about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
