On Sat, Jan 15, 2022 at 3:21 AM Nilesh Patra wrote:
>
> Hi Tong,
>
> On 1/15/22 2:55 AM, Tong Sun wrote:
> >> Hi,
> >>
> >> The situation should have been fixed with the new upload of easygen.
> >>
> >> However, the CI build is still failing in salsa. This is something
> >> that I don't understand as it builds OK on github.
> >>
> >> Sorry I've run out of ideas why it is happening like this, and am now
> >> thinking to remove the build dependency of easygen, to fix this and to
> >> make things easier...
> >
> > I still don't have a clue why
>
> I intended to reply earlier, but I was occupied and simply forgot later,
> sorry about that!
Oh, that's perfectly fine.
> > I'll wait for one or two weeks more, and if still nobody can help,
>
> It is usually a good idea to ask on #debian-mentors if there is more delay in
> a reply.
> Also, feel free to ping me if you think I can be of any help.
Oh, I only wrote that because I got total silence from my first
request. Now I know, that you'll still willing to help, just were busy
with something else. That promise alone, I'm forever grateful.
I'll keep it in mind but I won't ping anyone unless it's super urgent.
I normally give people a week, only after that I'll do a short follow
up, even at work, unless it's more urgent. Thanks again for helping.
> > it builds OK on github but fails in
> > salsa CI build, and I still hope that somebody can help.
>
> Okay, so there are two parts to it.
>
> 1) Why does github CI pass?
> Ok, so there are two reasons about this as well
> + test-all.sh does not seem to run anywhere in your github actions/CI and
> that error stems from this script (in the deb package)
> + `go test -v` in your CI essentially does nothing since there are no
> _test.go files and it is visible
> on the CI too
>
> | go test -v ./...
> | shell: /usr/bin/bash -e {0}
> | env:
> | GOROOT: /opt/hostedtoolcache/go/1.15.15/x64
> | github.com/suntong/ffcvt
> | ? github.com/suntong/ffcvt [no test files]
>
> So you probably should update it accordingly there as well.
Ah, good catch. fixed upstream. See
https://github.com/suntong/ffcvt/runs/4830553950?check_suite_focus=true
> 2) For salsa CI, I thought that it is because of the failing build.
> You will find the build failure logs pasted at the end of this email.
> The reason for test to be failing is that you have not updated
> "test/ffcvt_test.txt" file in accordance with the
> latest manpage/latest ffcvt options upstream.
>
> However, even after I have pushed a patch to fix the build, salsa CI chokes.
>
>
> > I'll remove the build dependency of easygen as planned, as I know for
> > sure it can fix the issue
> I am not sure if that's the problem here. Why would it fix the issue?
Ok, that does need a bit of explanation.
- ffcvt has the build dependency of easygen.
- the older version of easygen cause the initial v1.7.5 build failure
- which should be fixed by the updated easygen (from 4.1.0-1 to 5.1.9-2)
- that's why I triggered a rebuild (e673085)
- yet that rebuild still failed.
This is why I'm asking for help, as I don't understand why it still fails.
>From https://salsa.debian.org/go-team/packages/ffcvt/-/jobs/2342864#L719
the failure is caused by
config.go:1:1: expected 'package', found 'EOF'
which is in turn caused by
https://salsa.debian.org/go-team/packages/ffcvt/-/blob/master/debian/rules#L20
that
rm -f ... config.go
statement.
Everything builds fine locally, even with sbuild --
https://paste.debian.net/1227301/
That's why I don't understand why it fails in salsa CI, even after
I've done a brand new push to salsa --
https://salsa.debian.org/go-team/packages/ffcvt/-/jobs/2372315
I know removing the build dependency of easygen will work because I
don't need to do `rm -f ... config.go` after that.
> @Alois, could you shed some light on the CI thingy?
> From the logs, it is hard to figure out what went wrong.
> The packages that are shown failing there do not have anything to do with
> ffcvt package, are the failing logs stored somewhere?
Yes please @Alois.
> >> Somebody help please.
>
> Hope that helps. Let me know if you need sponsoring.
Yes, indeed Nilesh, as I'm not allowed to do dput myself yet. Please
do when all dust settles.
Thanks!
