On Tue, 14 Jun 2022 21:57:44 +0000 Matteo Bini <[email protected]> wrote:
Hi Bastian.
I've uploaded a new version on mentors, using the SourceForge source but
keeping the GitHub watch file, since it's where there's the most code activity
due to issues and pull requests, and I've included gnukem_datasrc files as
well.
The watch file is about watching and downloading releases, not code activity.
And this project releases the source packages on Sourceforge. Please use the
attached watch file. That does not repack the data component adding the src
component
but has a separate component.
Actually, looking at man uscan I wanted to set the version parameter for the
data
component to "same" but that did not work as expected.
Please do not manually repack things when it is not necessary like in this case.
When you have to do that, add a README.source on how to do it.
If you think that SDL 1.2 is too old and that new packages shouldn't use it,
I will try to contact upstream to ask to port davegnukem to SDL 2.0.
I will sponsor regardless but you should ask upstream anyway.
Please install HISTORY.txt as upstream changelog, not just a plain doc.
d/copyright
===========
I do not see the following license comment represented by the current
d/copyright:
"2018-03-22 Add boots sprite made by freepik.com, from flaticon.com, license
Creative Commons BY 3.0"
Where do you get the possible GPL license versions from? I cannot find them.
It is usually not a good idea to have debian/* licensed under a license that is
only compatible with
a subset of the upstream license. I would really like to see your contribution relicensed to Expat or the exact
combination that upstream is licensed under.version=4
opts=pgpmode=none,compression=gzip \
https://sf.net/gnukem/dave_gnukem-source-(\d\S+)\.zip debian
opts=pgpmode=none,component=data,filenamemangle=s/.+\/v?(\d\S+)\.tar\.gz/gnukem_data-$1\.tar\.gz/
\
https://github.com/davidjoffe/gnukem_data/tags .*/v?(\d\S+)\.tar\.gz
opts=pgpmode=none,component=datasrc \
https://github.com/davidjoffe/gnukem_datasrc/tags .*/v?(\d\S+)\.tar\.gz
ignore uupdate
