Xiyue Deng <manp...@gmail.com> writes: > Hi Sean, > > Thanks for the review! I initially thought d/changelog should mainly be > about user-facing changes. But looks like it's better to be thorough. > Please see replies inline below. > > Sean Whitton <spwhit...@spwhitton.name> writes: > >> control: tag -1 + moreinfo >> control: owner -1 ! >> >> Hello Xiyue, >> >> Thank you for working on this. >> A review of 2ea5e050fe78c7a382a613bc60ce5f14da4f130a: >> >> I'm wondering why you've updated git watch to check for the git HEAD, >> since upstream seems to now be tagging releases? >> > > I could have mixed the impression with other repos that don't have it. > Now tracking tags and slightly modernize it using "@ANY_VERSION@". > >> The changelog should mention the switch d/compat -> debhelper-compat. >> > > Done. > >> The typo fix in d/control should be mentioned in d/changelog. >> > > Done. > >> You should say that it's --parallel that you dropped from d/rules. >> > > Done. > >> Your justification for dropping the Built-Using should not be that >> Lintian suggested dropping it. Please determine the real reason :) > > I thought mentioning dropping Built-Using from arch:all package could be > an acceptable reason, which in turn also follows Lintian's suggestion :) > But do let me know if I should further clarify. > > New updates pushed to team repo and reuploaded to mentors. PTAL. TIA!
Friendly ping :) -- Xiyue Deng
signature.asc
Description: PGP signature
