Control: tags -1 moreinfo Hi Julius,
a short review based on the dsc uploaded 2024-02-02 22:10 d/control: - Initial packagin starts at Debian revision -1 (yours is -3) d/patches; - Remove, as empty. d/control: - its up to you to keep the comments, but then you need to maintain them and keep them up to date. However, as the information you write in the comment is already given by the Build-Depends: field, it would be redudant for me, I would remove them completly. - Some of your versioned Build-Depends are available since at least oldstable. In this case, remove the version constraint. (cmake and bison) - VCS-* points to where the package is maintained, not upstream. Please update the link, preferable to a repository on salsa. I can create one for you either in the Debian namespace of games-team namespace and grant you all rights you need. Let me know. (Note: I do not sponsor uploads of new packages if the packaging is not maintained on salsa. This does not consitute a promise that I will sponsor if it on salsa, though.) - As you've asked the games team for sponsoring, please put it under the umbrella of the games team. d/gbp.conf: - seems that there is some git repo ;) - you should also use pristine-tar and enable sign-tags d/source/lintian-overrides: - please limit the usage of wildcards to the minimum, so that new instances of the override will be caught in future versions of the d/rules: - it seems that you leave out some tests, due to it pulling stuff from the web. This is the right way during build, as you cant download. However, you can download stuff in autopkgtest, so you should implement autopkgtest. d/changelog: - update the timestamp. (dch -r "") Tagging "moreinfo", remove the tag when you've got something ready for review. -- Cheers, tobi
