Hi Stéphane! Thanks for reviewing it.
On Tue, Apr 23, 2024 at 7:57 PM Stéphane Glondu <glo...@debian.org> wrote: > > Dear Bo, > > On Mon, 4 Mar 2024 16:40:29 +0800 Bo YU <tsu.y...@gmail.com> wrote: > > I am looking for a sponsor for my package "ocaml-linenoise": > > Here is my review of the packaging: > > - There is a comment about ocaml-parany in debian/salsa-ci.yml I don't > understand. Ah, sorry, I forgot to drop it when I referred to the salsa yaml file of ocaml-cpu[0]. Now I update it with more precise salsa ci target. But to my confusion, I can not enable the ci on salsa repo on my side. > > - In debian/liblinenoise-ocaml.install.in, the *.cma should not be > prefixed by "OPT: " and the *.cmxs should be prefixed by "DYN: ". Done. I mixed them sometime but I think I will have a clear understanding of these files. Thanks again. BR, Bo [0]: https://salsa.debian.org/ocaml-team/ocaml-cpu/-/blob/master/debian/salsa-ci.yml?ref_type=heads > Cheers, > > -- > Stéphane >
