Control: reopen -1 Control: tags -1 + moreinfo Tous,
Preamble...
Thank you for taking the time to create this package and your contribution
to the Debian project.
The review below is for assistance. This review is offered to help
package submitters to Debian mentors inorder to improve their packages
prior to possible sponsorship into Debian. There is no obligation on behalf
of the submitter to make any alterations based upon information provided
in the review.
Review...
1. Build[1]: Good
2. Lintian[2]: Good
3. Licenses (lrc[3]): Issue
philwyett@ks-windu:~/Development/builder/debian/mentoring/samplebrain-0.18.5$
lrc
: Versions: recon 1.12 check 3.3.9-1
Parsing Source Tree ....
Reading copyright ....
Running licensecheck ....
d/copyright | licensecheck
GPL-2+ | Expat and/or X11 brain/src/aquila/Exceptions.h
GPL-2+ | Expat brain/src/aquila/LICENCE
GPL-2+ | Expat and/or X11 brain/src/aquila/aquila.h
GPL-2+ | Expat and/or X11 brain/src/aquila/filter.h
GPL-2+ | Expat and/or X11 brain/src/aquila/filter/MelFilter.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/filter/MelFilter.h
GPL-2+ | Expat and/or X11 brain/src/aquila/filter/MelFilterBank.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/filter/MelFilterBank.h
GPL-2+ | Expat and/or X11 brain/src/aquila/functions.h
GPL-2+ | Expat and/or X11 brain/src/aquila/global.h
GPL-2+ | Expat and/or X11 brain/src/aquila/ml.h
GPL-2+ | Expat and/or X11 brain/src/aquila/ml/Dtw.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/ml/Dtw.h
GPL-2+ | Expat and/or X11 brain/src/aquila/ml/DtwPoint.h
GPL-2+ | Expat and/or X11 brain/src/aquila/source.h
GPL-2+ | Expat and/or X11 brain/src/aquila/source/Frame.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/source/Frame.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/FramesCollection.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/source/FramesCollection.h
GPL-2+ | Expat and/or X11 brain/src/aquila/source/PlainTextFile.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/source/PlainTextFile.h
GPL-2+ | Expat and/or X11 brain/src/aquila/source/RawPcmFile.h
GPL-2+ | Expat and/or X11 brain/src/aquila/source/SignalSource.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/source/SignalSource.h
GPL-2+ | Expat and/or X11 brain/src/aquila/source/WaveFile.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/source/WaveFile.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/WaveFileHandler.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/source/WaveFileHandler.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/generator/Generator.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/source/generator/Generator.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/generator/PinkNoiseGenerator.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/source/generator/PinkNoiseGenerator.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/generator/SineGenerator.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/source/generator/SineGenerator.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/generator/SquareGenerator.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/source/generator/SquareGenerator.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/generator/TriangleGenerator.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/source/generator/TriangleGenerator.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/generator/WhiteNoiseGenerator.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/source/generator/WhiteNoiseGenerator.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/window/BarlettWindow.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/source/window/BarlettWindow.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/window/BlackmanWindow.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/source/window/BlackmanWindow.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/window/FlattopWindow.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/source/window/FlattopWindow.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/window/GaussianWindow.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/source/window/GaussianWindow.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/window/HammingWindow.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/source/window/HammingWindow.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/window/HannWindow.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/source/window/HannWindow.h
GPL-2+ | Expat and/or X11
brain/src/aquila/source/window/RectangularWindow.h
GPL-2+ | Expat and/or X11 brain/src/aquila/synth.h
GPL-2+ | Expat and/or X11
brain/src/aquila/synth/KarplusStrongSynthesizer.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/synth/KarplusStrongSynthesizer.h
GPL-2+ | Expat and/or X11 brain/src/aquila/synth/SineSynthesizer.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/synth/SineSynthesizer.h
GPL-2+ | Expat and/or X11 brain/src/aquila/synth/Synthesizer.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/synth/Synthesizer.h
GPL-2+ | Expat and/or X11 brain/src/aquila/tools.h
GPL-2+ | Expat and/or X11 brain/src/aquila/tools/TextPlot.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/tools/TextPlot.h
GPL-2+ | Expat and/or X11 brain/src/aquila/transform.h
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/AquilaFft.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/AquilaFft.h
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/Dct.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/Dct.h
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/Dft.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/Dft.h
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/Fft.h
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/FftFactory.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/FftFactory.h
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/Mfcc.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/Mfcc.h
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/OouraFft.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/OouraFft.h
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/Spectrogram.cpp
GPL-2+ | Expat and/or X11 brain/src/aquila/transform/Spectrogram.h
GPL-2+ | Expat and/or X11
brain/src/aquila/wrappers/SoundBufferAdapter.cpp
GPL-2+ | Expat and/or X11
brain/src/aquila/wrappers/SoundBufferAdapter.h
GPL-2+ | Expat and/or X11 brain/src/mfcc.cpp
GPL-2+ | Expat and/or X11 brain/src/mfcc.h
GPL-2+ | Expat brain/src/spiralcore/fixed.h
4. Watch file (uscan --force-download): Good
5. Build Twice (sudo pbuilder build --twice <package>.dsc): Good
6. Reproducible builds (reporotest)[3]:
7. Install (No previous installs): Good
8. Upgrade (Over previous installs if any): N/A
Additional...
A. Please update 'Standards-Version' in 'debian/control' to latest 4.7.0 as
per Debian policy[5].
Summary...
I believe samplebrain is not yet ready for sponsorship/upload. Could the
contributor rectify one of more of the rasied issues. Once updated to your
satisfaction and a new upload done, please remove the 'moreinfo' on the
Request For Sponsorship (RFS) bug report.
Regards
Phil
[1] Using:
* pbuilder - https://wiki.ubuntu.com/PbuilderHowto.
* https://wiki.debian.org/PbuilderTricks
and
* sbuild - https://wiki.debian.org/sbuild.
[2] Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different, so be thorough.
[3] 'lrc' from 'licenserecon' is located in Debian testing and newer.
[4] https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
[5] https://www.debian.org/doc/debian-policy/
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Internet Relay Chat (IRC): kathenas
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
--
signature.asc
Description: This is a digitally signed message part
